Open
Conversation
Contributor
Author
|
@Wendong-Fan @Pakchoioioi Please review this PR |
Wendong-Fan
requested review from
a7m-1st and
fengju0213
and removed request for
4pmtong
bytecii
reviewed
Feb 13, 2026
| // Use Electron's webUtils.getPathForFile to get file paths | ||
| const fileData = dropped.map((f: File) => { | ||
| try { | ||
| const path = window.electronAPI.getPathForFile(f); |
Collaborator
There was a problem hiding this comment.
Should we get the absolute path as maybe there are symlinks.
| ]; | ||
| console.log('[Drag-Drop] Setting files:', newFiles); | ||
| onFilesChange?.(newFiles); | ||
| toast.success(`Added ${result.files.length} file(s)`); |
Collaborator
There was a problem hiding this comment.
Seems that now agent will not look at these attached files? If so we can notify user it will be supported soon something like that.
|
|
||
| console.log('[Drag-Drop] Processing dropped files:', dropped.length); | ||
|
|
||
| // Use Electron's webUtils.getPathForFile to get file paths |
Collaborator
There was a problem hiding this comment.
Maybe we should move these to another helper function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #156
Description
This PR implements drag-and-drop file upload functionality in the chatbox, allowing users to drag files directly into the input area instead of using the file picker button.
What this PR solves:
webUtils.getPathForFile()API to handle context isolationtest.webm
Technical implementation:
process-dropped-filesin main processwebUtils.getPathForFile()via preload script for secure file path accessInputBoxcomponent with async drag-drop handlersWhat is the purpose of this pull request?