Skip to content

Conversation

@bittoby
Copy link
Contributor

@bittoby bittoby commented Feb 9, 2026

Closes: #959

Description

Fixes models not seeing or using installed MCPs (e.g. Firecrawl). The frontend was loading local MCP config from Electron but always sending an empty installed_mcp in the chat request, so the backend never received the real MCP list. The request body now sends the actual local MCP config when starting a chat so the backend can connect to MCP servers and expose their tools to the model.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bittoby
Copy link
Contributor Author

bittoby commented Feb 9, 2026

@Wendong-Fan @Pakchoioioi Please review this PR.

@bittoby
Copy link
Contributor Author

bittoby commented Feb 9, 2026

@Wendong-Fan could you merge this pr?

Copy link
Contributor

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bittoby for the fix! LGTM

@Wendong-Fan Wendong-Fan added this to the Sprint 14 milestone Feb 10, 2026
@Wendong-Fan
Copy link
Contributor

Hi @bittoby, after investigating, I found that MCP functionality actually works correctly through the AddWorker path when users add an agent via AddWorker and select MCP tools, the new_agents[].mcp_tools is properly passed to the backend and processed

As @fengju0213 mentioned in the #959 (comment), the original issue might be a user configuration problem rather than a code bug, a cleaner approach might be to remove the unused mcpLocal code instead since it's loaded but never used, this would improve code quality without changing the intended behavior, i will update directly in your PR, WDYT?

@Wendong-Fan Wendong-Fan changed the title fix: pass local MCP config to backend instead of empty object chore: remove unused mcpLocal code in chatStore Feb 10, 2026
@Wendong-Fan Wendong-Fan merged commit 705e12f into eigent-ai:main Feb 10, 2026
6 checks passed
@bittoby bittoby deleted the fix/mcp-config-not-passed-to-backend branch February 10, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Verify that the Firecrawl MCP is functioning properly

2 participants