Fix configured model not taking effect for newly created providers #1184
+24
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After configuring a new custom model provider (e.g., minimax), the system continues using the cloud model (e.g., Claude) because
setModelType('custom')never executes.Root cause
In
handleVerify, after saving a new provider, the flow is:setForm(...)— async React state update with the newprovider_idhandleSwitch(idx, true)— readsform[idx].provider_idfrom the stale closureFor new providers,
provider_idis stillundefinedat step 2, so the/api/provider/prefercall fails validation (provider_id: int), thecatchswallows the error, andsetModelType('custom')inside thetryblock is skipped.Fix
providerIdparameter tohandleSwitch(mirrors existing pattern inhandleLocalSwitch)handleVerify, extractprovider_idfrom the freshly fetched provider list and pass it directly:Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.