Update MPGD envelopes to match Sept. CAD model#986
Merged
Conversation
mposik1983
requested review from
ShujieL,
bschmookler,
rahmans1,
veprbl and
wdconinc
for more information, see https://pre-commit.ci
ShujieL
reviewed
Nov 11, 2025
bschmookler
reviewed
Nov 13, 2025
fix inner barrel mpgd rmin
5 tasks
adjust disk inner opening according to the beampipe shape after z position changed.
- Overlap: Module radii now derived from "rmin" of envelope. - Cosmetics: "sector" changed for "section" + documentation of XML.
github-actions
bot
added
topic: barrel
Member
|
What is the status of this? |
Contributor
|
The MPGD and SVT positions/sizes are now consistent with the September 2025 CAD envelopes in this PR. Yann's last update fixed the overlap issue within the MPGD inner barrel detector that was introduced by the change of the envelope's inner radius. So, I think we are good to merge this and update the material map. |
Member
|
Does anyone approve the PR? |
bschmookler
approved these changes
Mar 25, 2026
Contributor
bschmookler
left a comment
bschmookler
left a comment
There was a problem hiding this comment.
This looks good. We can close the SVT PR (#1042), since the changes have been merged in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Update MPGD envelopes to match Sept. CAD model: https://indico.bnl.gov/event/29963/
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No breaking changes. MPGD hit locations will be altered and a new material map will need to be generated.
Does this PR change default behavior?
There will be changes in the hit locations of the MPGDs, most notably the MPGD disks as they had changes made to their outer radii and were moved closer to the IP.