Skip to content

epic: remove setup_run_environment#856

Open
veprbl wants to merge 1 commit intodevelopfrom
pr/epic_nosetup
Open

epic: remove setup_run_environment#856
veprbl wants to merge 1 commit intodevelopfrom
pr/epic_nosetup

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Mar 12, 2026

The value DETECTOR_PATH=/opt/local/share/epic are incorrect, they apply unconditionally (ignore external shell variables) and conflict with eic/containers@7b3d240

The value `DETECTOR_PATH=/opt/local/share/epic` are incorrect, they apply unconditionally (ignore external shell variables) and conflict with eic/containers@7b3d240
@veprbl veprbl requested a review from wdconinc March 12, 2026 19:58
@wdconinc
Copy link
Contributor

The value DETECTOR_PATH=/opt/local/share/epic are incorrect, they apply unconditionally (ignore external shell variables) and conflict with eic/containers@7b3d240

This is a spack bug? Can you report it? Two environments, and it uses the default environment view root instead of the environment that the package is projected in.

@veprbl
Copy link
Member Author

veprbl commented Mar 12, 2026

Not sure about the bug, I don't see how it even works. Looking at Dockerfile the views just magically appear in /opt/local and /opt/detector.

It doesn't work to use correct values either. It would help if spack could allow some softer variable settings ("set if not already set" type of thing) https://github.com/spack/spack/blob/9922e0216ec599a16fe4a7a0b4a6d69edf93a92c/lib/spack/spack/util/environment.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants