Open
Conversation
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on centralizing cuda_arch capability definition
Centralize cuda_arch capability definition
Mar 12, 2026
wdconinc
approved these changes
Mar 12, 2026
Contributor
wdconinc
left a comment
There was a problem hiding this comment.
Looks sensible. Maybe there's a risk this will enable cuda_arch and therefore +cuda for packages where we currently don't explicitly enable +cuda, but would that be a bad thing?
wdconinc
approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the CUDA compute capability setting for the Spack CUDA-related environments by introducing a shared cuda_arch.yaml include and removing per-spec cuda_arch=75 pins.
Changes:
- Add a new
spack-environment/cuda_arch.yamland include it from CUDA/TensorFlow environments. - Remove explicit
cuda_arch=75from CUDA-enabled specs inspack-environment/cuda/spack.yaml. - Remove explicit
cuda_arch=75from the TensorFlow CUDA spec inspack-environment/tf/spack.yaml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spack-environment/tf/spack.yaml | Includes centralized CUDA arch config; drops per-spec cuda_arch=75 on TensorFlow. |
| spack-environment/cuda/spack.yaml | Includes centralized CUDA arch config; drops per-spec cuda_arch=75 on multiple CUDA specs. |
| spack-environment/cuda_arch.yaml | New shared config intended to define CUDA architecture in one place. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
veprbl
approved these changes
Mar 13, 2026
wdconinc
reviewed
Mar 13, 2026
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for:
cuda_arch=75was duplicated across 5 package specs incuda/spack.yamlandtf/spack.yaml, making it hard to retarget GPU architecture.Changes
spack-environment/packages.yaml: Addedcuda_arch=75as a conditional requirement inpackages: all: requirewithwhen: '+cuda', so it applies to all CUDA-enabled packages without affecting CPU-only packages.cuda/spack.yamlandtf/spack.yaml: Drop inlinecuda_arch=75fromacts,arrow,celeritas,py-torch, andpy-tensorflowspecs.To target a different GPU architecture (currently Compute Capability 7.5 / Turing: T4, RTX 2xxx, Quadro RTX), change
cuda_arch=75in this single location.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.