fix: workaround jana2 issue with jana2_tutorial_podio#193
fix: workaround jana2 issue with jana2_tutorial_podio#193
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the EICSPACK_VERSION commit hash in eic-spack.sh to pick up a workaround for a jana2 issue with jana2_tutorial_podio, incorporating the upstream fix from eic/eic-spack#855 by pointing to a specific pre-release commit (7f6ce63).
Changes:
- Bump
EICSPACK_VERSIONto commit7f6ce6379e29f6154a67f68c56ede4b9bc96b558to include the jana2/jana2_tutorial_podio workaround from the upstream eic-spack repository.
| ## EIC spack commit hash or github version, e.g. v0.19.7 | ||
| ## note: nightly builds could use a branch e.g. releases/v0.19 | ||
| EICSPACK_VERSION="c6c0b369542bf60e79f684fb4a37f8c766dff230" | ||
| EICSPACK_VERSION="7f6ce6379e29f6154a67f68c56ede4b9bc96b558" # FIXME |
There was a problem hiding this comment.
The # FIXME comment on the EICSPACK_VERSION line indicates this commit hash is a temporary workaround rather than an intended stable pin. Looking at the other version files (key4hep-spack.sh, spack.sh), no # FIXME markers are used — commit hashes or version tags are set as clean assignments without todo markers. Merging a # FIXME annotation to the main branch risks leaving a stale marker that is confusing to future contributors and signals the change is not production-ready. The comment should be replaced with a brief descriptive note (e.g., referencing the upstream PR being incorporated) or removed entirely before merging.
| EICSPACK_VERSION="7f6ce6379e29f6154a67f68c56ede4b9bc96b558" # FIXME | |
| EICSPACK_VERSION="7f6ce6379e29f6154a67f68c56ede4b9bc96b558" |
Adds eic/eic-spack#855