fix: drop duplicate session params from generated task template (#2)#8
Merged
Merged
Conversation
) Session-wide keys (max_reward, min_reward, hydrate_delay, ...) live in both SessionParameters and the experiment default_key by design, but the ethopy-create-task template was emitting them in both session_params and experiment_conditions. Filter exp_params against SessionParameters annotations so each key appears in exactly one place. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethopy-create-taskwas emittingmax_reward,min_reward, andhydrate_delayin bothsession_paramsandexperiment_conditionsfor MatchPort + MultiPort templates (and any experiment whosedefault_keyoverlaps withSessionParameters).SessionParameters.__annotations__before formatting, using the existing dataclass as the single source of truth so future session keys are stripped automatically.Closes #2
Test plan
ethopy-create-taskwith experimentexperiments.match_port/ behaviorbehaviors.multi_portand confirmexperiment_conditionsno longer containsmax_reward,min_reward, orhydrate_delay.session_paramsblock still contains those keys.trial_selection,init_ready,trial_duration, ...) are still emitted.🤖 Generated with Claude Code