fix: grant course staff exam access tokens #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -815,6 +815,26 @@ def test_access_no_due_date(self, attempt_status, response_status): | |||
| if response_status == 200: | |||
| self.assert_valid_exam_access_token(response, self.user, no_due_date_exam) | |||
|
|
|||
| def test_access_user_is_course_staff(self): | |||
| """ | |||
| Verify the endpoint grants access for an exam | |||
There was a problem hiding this comment.
If you agree with my suggestion below, please update the docstring and the test.
edx_exams/apps/api/v1/views.py
Outdated
| @@ -385,6 +385,10 @@ def get_response(cls, exam, user): | |||
| elif exam.due_date is not None and timezone.now() >= exam.due_date: | |||
| grant_access, response_status = True, status.HTTP_200_OK | |||
|
|
|||
| # If user is course staff, then grant them access | |||
There was a problem hiding this comment.
This is what we want, but I think we should have this before line 369. On the frontend, access to the contents of the exam will always be granted to staff members. Because of this, they never see any exam functionality and will not be able to start an exam attempt. Therefore, we can short circuit early and give them access immediately if they are a staff member - no need to look at exam attempts. This makes the code easier to reason about. Does that match your understanding?
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: Link to JIRA ticket
Description: Add a fix to allow course staff to view the exams they create, as currently some courses staff are blocked from viewing the exams they've created.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.
Dependencies: dependencies on other outstanding PRs, issues, etc.
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Merge checklist:
Post merge: