Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode course id and username for lms request #356

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix: encode course id and username for lms request #356

merged 1 commit into from
Jan 29, 2025

Conversation

alangsto
Copy link
Member

Query and path parameters need to be re-encoded before being included in requests to the LMS.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Delete working branch (if not needed anymore)

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  edx_exams/apps/router
  interop.py
  edx_exams/apps/router/tests
  test_interop.py
Project Total  

This report was generated by python-coverage-comment-action

varshamenon4
varshamenon4 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@varshamenon4 varshamenon4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alangsto alangsto merged commit bc9e56f into main Jan 29, 2025
4 checks passed
@alangsto alangsto deleted the alangsto/fix_onboarding_url branch January 29, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshamenon4 varshamenon4 varshamenon4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alangsto @varshamenon4