Skip to content

fix: mktg urls from the configuration #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −14
Open

fix: mktg urls from the configuration #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29ccaab
fix: mktg urls from the configuration
ktyagiapphelix2u Nov 7, 2025
37d5adf
fix: mktg urls from the configuration
ktyagiapphelix2u Nov 10, 2025
5b84a61
fix: mktg urls from the configuration
ktyagiapphelix2u Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions configuration_files/lms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ ELASTIC_SEARCH_CONFIG:
- host: edx.devstack.elasticsearch
port: 9200
use_ssl: false
ENABLE_MKTG_SITE: true
ENABLE_MKTG_SITE: true
EMAIL_BACKEND: django.core.mail.backends.smtp.EmailBackend
EMAIL_HOST: localhost
EMAIL_HOST_PASSWORD: ''
Expand Down Expand Up @@ -425,8 +425,10 @@ MKTG_URLS:
ROOT: http://localhost:18000
ABOUT: /about
CONTACT: /contact
FAQ: /help
COURSES: /course
COURSES: /courses
BLOG: /blog
DONATE: /donate
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FAQ key was removed from configuration_files/lms.yml but is still present in py_configuration_files/lms.py (line 437: 'FAQ': '/student-faq'). These two configuration files should remain consistent. Either add FAQ back to the YAML file or remove it from the Python file as well.

Suggested change
DONATE: /donate
DONATE: /donate
FAQ: /student-faq

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@chintanjoshi-apphelix-2u chintanjoshi-apphelix-2u Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks relevant comment

TOS_AND_HONOR: /tos
TOS: /edx-terms-service
HONOR: /honor
PRIVACY: /privacy
Expand Down
15 changes: 4 additions & 11 deletions py_configuration_files/lms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,31 +425,24 @@ def should_show_debug_toolbar(request): # lint-amnesty, pylint: disable=missing
})

ENABLE_MKTG_SITE = os.environ.get('ENABLE_MARKETING_SITE', True)
MARKETING_SITE_ROOT = os.environ.get('MARKETING_SITE_ROOT', 'http://localhost:8080')
MARKETING_SITE_ROOT = os.environ.get('MARKETING_SITE_ROOT', '/')
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing MARKETING_SITE_ROOT default from 'http://localhost:8080' to '/' is a significant behavioral change. The value '/' is a relative path rather than a full URL, which may cause issues when constructing absolute URLs for marketing site links.

If this is intentional to support relative paths, ensure that:

  1. All code using MARKETING_SITE_ROOT can properly handle relative paths
  2. The change is documented and tested
  3. Consider if this affects external link generation or redirects

Alternatively, if this should remain an absolute URL, consider using 'http://localhost:18000' to match the typical LMS development environment.

Suggested change
MARKETING_SITE_ROOT = os.environ.get('MARKETING_SITE_ROOT', '/')
MARKETING_SITE_ROOT = os.environ.get('MARKETING_SITE_ROOT', 'http://localhost:18000')

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@chintanjoshi-apphelix-2u chintanjoshi-apphelix-2u Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktyagiapphelix2u Can this entire setting be removed ?

As we already have MKTG_URLS['ROOT'] so should we rely on this variable anymore ?

Can you check with @robrap or in general with community on this ?


MKTG_URLS = {
'ABOUT': '/about',
'ACCESSIBILITY': '/accessibility',
'AFFILIATES': '/affiliate-program',
'BLOG': '/blog',
'CAREERS': '/careers',
'CONTACT': '/support/contact_us',
'COURSES': '/course',
'COURSES': '/courses',
'DONATE': '/donate',
'ENTERPRISE': '/enterprise',
'FAQ': '/student-faq',
'HONOR': '/edx-terms-service',
'HOW_IT_WORKS': '/how-it-works',
'MEDIA_KIT': '/media-kit',
'NEWS': '/news-announcements',
'PRESS': '/press',
'PRIVACY': '/edx-privacy-policy',
'PRIVACY': '/privacy',
'ROOT': MARKETING_SITE_ROOT,
'SCHOOLS': '/schools-partners',
'SITE_MAP': '/sitemap',
'TRADEMARKS': '/trademarks',
'TOS': '/edx-terms-service',
'TOS_AND_HONOR': '/edx-terms-service',
'TOS_AND_HONOR': '/tos',
'WHAT_IS_VERIFIED_CERT': '/verified-certificate',
'PROGRAM_SUBSCRIPTIONS': '/program-subscriptions',
}
Expand Down
Loading