Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update payment page redirect for program #326

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

attiyaIshaque
Copy link
Member

@attiyaIshaque attiyaIshaque commented Jan 30, 2025

Description

The existing pipeline has been updated. It checks the program's availability; if the program is available in CT, it will remain to CT. If it's not available, it will move to the legacy system. All of this functionality has been implemented behind a feature flag.

Copy link

github-actions bot commented Jan 30, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  clients.py 380-392
  commerce_coordinator/apps/lms
  views.py
  commerce_coordinator/apps/rollout
  pipeline.py 52-55
  waffle.py
Project Total  

This report was generated by python-coverage-comment-action

@attiyaIshaque attiyaIshaque force-pushed the attiya/SONIC-858-update-payment-page-redirect branch from 2d9cb4a to 413fd13 Compare February 6, 2025 08:15
@attiyaIshaque attiyaIshaque marked this pull request as ready for review February 6, 2025 08:15
Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@shafqatfarhan can you please review it as well?

@attiyaIshaque attiyaIshaque force-pushed the attiya/SONIC-858-update-payment-page-redirect branch from 413fd13 to fe2ec49 Compare February 7, 2025 09:20
@attiyaIshaque attiyaIshaque merged commit ddf10ad into main Feb 10, 2025
8 checks passed
@attiyaIshaque attiyaIshaque deleted the attiya/SONIC-858-update-payment-page-redirect branch February 10, 2025 07:58
attiyaIshaque added a commit that referenced this pull request Feb 10, 2025
attiyaIshaque added a commit that referenced this pull request Feb 10, 2025
@attiyaIshaque attiyaIshaque restored the attiya/SONIC-858-update-payment-page-redirect branch February 10, 2025 08:29
abdullahwaheed added a commit that referenced this pull request Mar 11, 2025
abdullahwaheed added a commit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants