Install Agent Skills to Claude Code, Pi, and omp skills directories#218
Merged
Conversation
Wires the four agentSkills/*/SKILL.md files (recall-doctor, recall-loa, recall-stats, recall-update) into the install/update/uninstall lifecycle: - Fixed a content bug: all four skills invoked a nonexistent `mem` CLI (leftover from whatever generated them) instead of this repo's actual `recall` binary. - lib/install-lib.sh: two shared helpers (_recall_copy_skill_files, _recall_link_skills_to) do the canonical-copy + per-file-symlink work once; every platform entry point (Claude, Pi, omp) and both install.sh and update.sh call through them — no per-platform duplication. - Claude Code skills install unconditionally (core platform, like slash commands); Pi and omp are gated behind their existing/new detection flags (OMP_DETECTED added alongside OPENCODE_DETECTED/PI_DETECTED). - omp is skills-only for now — no MCP/hooks integration exists for it in this repo, so recall_install_omp_platform only handles skills. - uninstall.sh removes only the four Recall-owned skill directories (RECALL_SKILL_NAMES), preserving any other skills a user has installed in the same directory. New --skip-omp flag mirrors --skip-pi/-opencode. - recall_verify_install's post-install check now covers skill symlinks. Tests: 8 new (tests/install/skills.test.ts + update.test.ts topology case), full suite 1207/1207 passing, bash -n clean on all 4 scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentSkills/*/SKILL.mdfiles (recall-doctor,recall-loa,recall-stats,recall-update) into the install/update/uninstall lifecycle, installing them to~/.claude/skills,~/.pi/agent/skills, and~/.omp/agent/skills.memCLI (leftover from whatever generated them) — corrected torecall, this repo's actual binary.ompis a new, skills-only platform (no MCP/hooks integration exists for it yet in this repo) — gated behind a newOMP_DETECTEDflag alongside the existingOPENCODE_DETECTED/PI_DETECTED.uninstall.shremoves only the four Recall-owned skill directories (RECALL_SKILL_NAMES), preserving any other skills a user has installed alongside them. New--skip-ompflag mirrors--skip-pi/--skip-opencode.Design
lib/install-lib.sh(_recall_copy_skill_files,_recall_link_skills_to) do the canonical-copy + per-file-symlink work once. Every platform entry point (Claude, Pi, omp) and bothinstall.shandupdate.shcall through them — no per-platform duplication (per this repo's DRY mandate).recall_verify_install's post-install self-check now also covers skill symlinks, same pattern as slash commands.Test plan
bash -nclean oninstall.sh,update.sh,uninstall.sh,lib/install-lib.shbun run lintcleantests/install/skills.test.ts(7 cases: canonical copy + symlink, idempotency, Pi/omp targets, foreign-symlink collision handling, uninstall preserves foreign skills,--dry-run) + 1 new call-topology case intests/install/update.test.tsfor omp refresh🤖 Generated with Claude Code