Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlmodel #564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sqlmodel #564

wants to merge 2 commits into from

Conversation

vpetrovykh
Copy link
Member

There are two commits. The first one is mostly tweaks based on the feedback about the ORM schema generators. The second one adds SQLModel schema generator (that's very similar to SQLAlchemy).

@vpetrovykh
Update the ORM schema generators.
474702b 
Replace "backlink_via_" pattern with "back_to_" and
"follow_linkt_back_to_" naming convention for backlinks.
@vpetrovykh vpetrovykh requested a review from a team January 21, 2025 18:52
@vpetrovykh
Add sqlmodel to gel-orm generator.
f13893b 
This is similar to SQLAlchemy model generator, but the results are
SQLModels instead.
msullivan
msullivan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything in specific you want me to look closely at? I mostly skimmed this, since it is very similar to sqlalchemy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vpetrovykh @msullivan