Conversation
Agent skills in the amp repository are not release assets and link docs that live elsewhere in the repository, so ampup reads them from the source tarball of a git ref and bundles those links into self-contained skill directories. - Add `ampup skills add|list|update|remove` for Claude Code, Codex, and Cursor, in the project or `--global`, defaulting to the skills of the active ampd version and pinnable with `--ref` or `--pr <number>` (the pull request head commit) - Copy files linked from `SKILL.md` frontmatter `metadata.references`/`assets` into `references/` and `assets/`, and record repo, ref, and commit in an `.amp-skills.json` lock file so skills ampup did not install are never touched - Validate skill names as single path components so a tampered lock file or `--skill` value cannot reach outside the skills directory, and record the lock entry before installing so interrupted installs are retried - Print results to stdout as text or `--json`, status to stderr, confirm `remove` unless `--force`, and print error causes from the top-level handler - Add `GitHubClient::resolve_commit`, `resolve_pull_request_head`, and `download_source_tarball`, which streams the tarball to an anonymous temporary file read in two passes, plus typed `thiserror` errors and end-to-end tests against a mock GitHub API Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent skills in the amp repository are not release assets and link docs that live elsewhere in the repository, so ampup reads them from the source tarball of a git ref and bundles those links into self-contained skill directories.
ampup skills add|list|update|removefor Claude Code, Codex, and Cursor, in the project or--global, defaulting to the skills of the active ampd version and pinnable with--refor--pr <number>(the pull request head commit)SKILL.mdfrontmattermetadata.references/assetsintoreferences/andassets/, and record repo, ref, and commit in an.amp-skills.jsonlock file so skills ampup did not install are never touched--skillvalue cannot reach outside the skills directory, and record the lock entry before installing so interrupted installs are retried--json, status to stderr, confirmremoveunless--force, and print error causes from the top-level handlerGitHubClient::resolve_commit,resolve_pull_request_head, anddownload_source_tarball, which streams the tarball to an anonymous temporary file read in two passes, plus typedthiserrorerrors and end-to-end tests against a mock GitHub APICloses edgeandnode/amp#3131