Conversation
…ctor to provider Move all connection/client code (client, error, metrics, evm, proto, tables, build.rs, proto definitions) from the firehose extractor crate into the provider crate. The extractor now only contains dataset schema types (Manifest, Table, DatasetKind). This lets providers-registry depend on the provider crate directly instead of the extractor for client construction.
mitchhs12
force-pushed
the
mitchhs12/firehose-provider-source-decoupling
branch
from
8b799d0 to
bec847b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firehose-datasetsextractor intoamp-providers-firehoseprovider crateproviders-registrynow depends on the provider crate directly for Firehose client construction, removing its dependency on the extractormod.rsconvention violations (evm/mod.rs→evm.rs,proto/mod.rs→proto.rs)Same pattern as #1898 (EVM-RPC).
After this,
providers-registryno longer depends on the EVM-RPC or Firehose extractor crates.Solana is still the same though.