refactor(metadata-db): migrate tests from Connection to MetadataDb pool#1904
Merged
shiyasmohd merged 1 commit intomainfrom Mar 4, 2026
Merged
refactor(metadata-db): migrate tests from Connection to MetadataDb pool#1904shiyasmohd merged 1 commit intomainfrom
shiyasmohd merged 1 commit intomainfrom
Conversation
LNSD
approved these changes
Mar 4, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
LGTM ✅
Nit: Would you mind renaming the tests::common module name to tests::helpers?
shiyasmohd
force-pushed
the
shiyasmohd/migrate-tests
branch
from
789eb78 to
98a7f99
Compare
Contributor
Author
|
Renamed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual Connection setup with shared
setup_test_db()helper, removing boilerplate code.