Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #165

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Improve test coverage #165

merged 3 commits into from
Mar 24, 2025

Conversation

marcosbento
Copy link
Collaborator

No description provided.

- Move conversion functions to Calendar.(h|c)pp
- Remove unnecessary Cal
- Add tests for the convertion
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 97.64706% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.09%. Comparing base (0f3621b) to head (fd175a0).

Files with missing lines Patch % Lines
Viewer/ecflowUI/src/VRepeatAttr.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
+ Coverage    48.94%   49.09%   +0.14%     
===========================================
  Files         1189     1188       -1     
  Lines        98454    98706     +252     
  Branches     14750    14751       +1     
===========================================
+ Hits         48193    48456     +263     
+ Misses       50261    50250      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento merged commit f2b1750 into develop Mar 24, 2025
106 checks passed
@marcosbento marcosbento deleted the feature/improve_coverage branch March 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants