-
Notifications
You must be signed in to change notification settings - Fork 31
Rpc client u subscription #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rpc client u subscription #324
Conversation
Code coverage report is ready! 📈
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MaximilianToe -- thanks for contributing!
I noted more up-spec-related items and have tagged @sophokles73 and @stevenhartley onto the PR as there may be gaps in the spec (or in my understanding of it!)
include/up-cpp/client/usubscription/v3/RpcClientUSubscription.h
Outdated
Show resolved
Hide resolved
Code coverage report is ready! 📈
|
@PLeVasseur would you mind taking another look? |
Yup, will do. Try to make it fit this week 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates @MaximilianToe! Can you take a look at the comments I left?
It feels to me there's still a bit of alignment work to ensure that the C++ RpcClient API mimics the Rust equivalent. Happy to hear your thoughts.
# Conflicts: # include/up-cpp/communication/RpcClient.h
701bfdf
to
6aae8ea
Compare
Code coverage report is ready! 📈
|
This pull request provides the following: