Skip to content

Rpc client u subscription #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MaximilianToe
Copy link
Contributor

This pull request provides the following:

  • An interface for a USubscriptionClient in USubscription.h
  • An Implementation of that interface in RpcClientUSubscription.cpp/RpcClientUSubscription.h
  • A template method InvokeProtoMethod to send and receive requests with a specific payload type in RpcClient.h similar to the one present in up-rust
  • A helper request builder and uuri builder
  • Extracting part of Consumer.cpp that was also needed for USubscription to avoid code duplication

Copy link

github-actions bot commented Jun 9, 2025

Code coverage report is ready! 📈

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaximilianToe -- thanks for contributing!

I noted more up-spec-related items and have tagged @sophokles73 and @stevenhartley onto the PR as there may be gaps in the spec (or in my understanding of it!)

Copy link

Code coverage report is ready! 📈

@sophokles73
Copy link

@PLeVasseur would you mind taking another look?

@PLeVasseur
Copy link
Contributor

Yup, will do. Try to make it fit this week 👍

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates @MaximilianToe! Can you take a look at the comments I left?

It feels to me there's still a bit of alignment work to ensure that the C++ RpcClient API mimics the Rust equivalent. Happy to hear your thoughts.

@MaximilianToe MaximilianToe force-pushed the RpcClientUSubscription branch from 701bfdf to 6aae8ea Compare August 11, 2025 19:45
Copy link

Code coverage report is ready! 📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants