Repository navigation
Conversation
mrdeep1
force-pushed
the
sanitizer
branch
3 times, most recently
from
September 18, 2026 14:37
2099a3c to
f155acf
Compare
boaks
reviewed
Sep 19, 2026
| #define CCM_FLAGS(A,M,L) (((A > 0) << 6) | (((M - 2)/2) << 3) | (L - 1)) | ||
|
|
||
| #define MASK_L(_L) ((1 << 8 * _L) - 1) | ||
| #define MASK_L(_L) (((size_t)1 << (8 * _L)) - 1) |
Contributor
Author
There was a problem hiding this comment.
Thanks for the pointer. It needs to be uint64_t for m32 builds.
boaks
reviewed
Sep 19, 2026
| dtls_hash_update(&ctx->data, key, klen); | ||
| dtls_hash_finalize(ctx->pad, &ctx->data); | ||
| } else | ||
| } else if (key) |
Contributor
There was a problem hiding this comment.
Not sure, but if key must be checked, then that must be above that, the other if branch is also using key.
Contributor
There was a problem hiding this comment.
Maybe the logic is, if klen is 0, key maybe NULL.
Contributor
Author
|
Just updated to include m32 testing. |
obgm
reviewed
Oct 5, 2026
| fi | ||
|
|
||
| AC_ARG_ENABLE([sanitize], | ||
| [AS_HELP_STRING([--enable-sanitize], |
Contributor
There was a problem hiding this comment.
Should be --enable-sanitizer.
For CMake and in the PR description, it is "sanitizer".
configure --enable-sanitizer cmake -DENABLE_SANITIZER=ON Addresses trivial issues raised by the ASan sanitizer. Includes m4/ax_check_compile_flag.m4, which is a part of the pkg autoconf-archive which not all systems have. Add sanitizer runs to CI. Signed-off-by: Jon Shallow <supjps-libcoap@jpshallow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure --enable-sanitizer
cmake -DENABLE_SANITIZER=ON
Addresses trivial issues raised by the ASan sanitizer.
Includes m4/ax_check_compile_flag.m4, which is a part of the pkg autoconf-archive which not all systems have.
Add sanitizer runs to CI.