Skip to content

chore: activate "prefer-const" eslint error #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

chore: activate "prefer-const" eslint error #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export default defineConfig([
"@typescript-eslint/no-floating-promises": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430

// **************** Enforce usage of `const` over `let` wherever possible, to prevent accidental reassignments
"prefer-const": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"prefer-const": "error",

// *************** Other rules ***************
"no-restricted-globals": "error",
Expand Down
22 changes: 11 additions & 11 deletions packages/core/src/consumed-thing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
throw new Error(`ConsumedThing '${this.title}' does not have property ${propertyName}`);
}

let { client, form } = this.getClientFor(tp.forms, "readproperty", Affordance.PropertyAffordance, options);
const { client, form } = this.getClientFor(tp.forms, "readproperty", Affordance.PropertyAffordance, options);
if (form == null) {
throw new Error(`ConsumedThing '${this.title}' did not get suitable form`);
}
Expand All @@ -598,11 +598,11 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
debug(`ConsumedThing '${this.title}' reading ${form.href}`);

// uriVariables ?
form = this.handleUriVariables(tp, form, options);
const formWithUriVariables = this.handleUriVariables(tp, form, options);

const content = await client.readResource(form);
const content = await client.readResource(formWithUriVariables);
try {
return this.handleInteractionOutput(content, form, tp);
return this.handleInteractionOutput(content, formWithUriVariables, tp);
} catch (e) {
const error = e instanceof Error ? e : new Error(JSON.stringify(e));
throw new Error(`Error while processing property for ${tp.title}. ${error.message}`);
Expand Down Expand Up @@ -698,7 +698,7 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
if (tp == null) {
throw new Error(`ConsumedThing '${this.title}' does not have property ${propertyName}`);
}
let { client, form } = this.getClientFor(tp.forms, "writeproperty", Affordance.PropertyAffordance, options);
const { client, form } = this.getClientFor(tp.forms, "writeproperty", Affordance.PropertyAffordance, options);
if (form == null) {
throw new Error(`ConsumedThing '${this.title}' did not get suitable form`);
}
Expand All @@ -710,8 +710,8 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
const content = ContentManager.valueToContent(value, tp, form.contentType);

// uriVariables ?
form = this.handleUriVariables(tp, form, options);
await client.writeResource(form, content);
const formWithUriVariables = this.handleUriVariables(tp, form, options);
await client.writeResource(formWithUriVariables, content);
}

async writeMultipleProperties(valueMap: WoT.PropertyWriteMap, options?: WoT.InteractionOptions): Promise<void> {
Expand Down Expand Up @@ -739,7 +739,7 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
if (ta == null) {
throw new Error(`ConsumedThing '${this.title}' does not have action ${actionName}`);
}
let { client, form } = this.getClientFor(ta.forms, "invokeaction", Affordance.ActionAffordance, options);
const { client, form } = this.getClientFor(ta.forms, "invokeaction", Affordance.ActionAffordance, options);
if (form == null) {
throw new Error(`ConsumedThing '${this.title}' did not get suitable form`);
}
Expand All @@ -759,11 +759,11 @@ export default class ConsumedThing extends Thing implements IConsumedThing {
}

// uriVariables ?
form = this.handleUriVariables(ta, form, options);
const formWithUriVariables = this.handleUriVariables(ta, form, options);

const content = await client.invokeResource(form, input);
const content = await client.invokeResource(formWithUriVariables, input);
try {
return this.handleActionInteractionOutput(content, form, ta.output, ta.synchronous);
return this.handleActionInteractionOutput(content, formWithUriVariables, ta.output, ta.synchronous);
} catch (e) {
const error = e instanceof Error ? e : new Error(JSON.stringify(e));
throw new Error(`Error while processing action for ${ta.title}. ${error.message}`);
Expand Down