Check NDEATH for matching bdseq - ignore otherwise #502 #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's ok to not worry about Edge Nodes sending invalid NDEATHs in this case. If they do this incorrectly, I would think they would also do it incorrectly in a valid OFFLINE state message with a current timestamp. So, I think we'd catch their flaw anyway. |
wes-johnson
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #502 - match NDEATH bdseq with NBIRTH..
I'm not entirely sure about this one - does the change leave us open to other errors such as the edge node issuing NDEATHS with wrong bdSeqs, in the case of the DONT_EXPECT_DEATHS state?