Skip to content

[libclang parser] include headers hermetically - #378

Merged
LittleHuba merged 1 commit into
mainfrom
joho_hermetic_libclang
Aug 5, 2026
Merged

[libclang parser] include headers hermetically#378
LittleHuba merged 1 commit into
mainfrom
joho_hermetic_libclang

Conversation

@hoe-jo

@hoe-jo hoe-jo commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  • introduce sysroot for libclang
  • wire it into libclang tooling

@hoe-jo
hoe-jo force-pushed the joho_hermetic_libclang branch from 39aa97e to 4d6ac6b Compare July 30, 2026 11:28
@github-actions

Copy link
Copy Markdown

Coverage Report

Coverage report was generated.

Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run).

Overall coverage rate:

lines......: 86.4%
functions......: 53.7%

@hoe-jo
hoe-jo force-pushed the joho_hermetic_libclang branch from 4d6ac6b to 0fbab6e Compare July 30, 2026 12:09
@github-actions

Copy link
Copy Markdown

Coverage Report

Coverage report was generated.

Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run).

Overall coverage rate:

lines......: 86.5%
functions......: 53.7%

@hoe-jo
hoe-jo force-pushed the joho_hermetic_libclang branch from 0fbab6e to 5bd3715 Compare August 3, 2026 09:28
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Coverage Report

Coverage report was generated.

Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run).

Overall coverage rate:

lines......: 86.6%
functions......: 54.0%

Comment thread MODULE.bazel Outdated
# build host, matching eclipse-score-communication2's ubuntu24_04_sysroot setup.
apt.install(
dependency_set = "tooling_sysroot",
mergedusr = True,

@LittleHuba LittleHuba Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump to 6e17a8b59c851243d612108a96d05bc77f6f58d1
Then remove mergedusr attribute and add package base-files to the list.

Comment thread MODULE.bazel Outdated
architecture = "amd64",
dependency_set = "tooling_sysroot",
)
apt.lock(into = "//:rules_distroless.lock.json")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop this line. It is only required for Bazel versions <8 which is outside of our compatibility level anyway.

Comment thread rules_distroless.lock.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed when the lock tag is dropped.

@hoe-jo
hoe-jo force-pushed the joho_hermetic_libclang branch 2 times, most recently from 0ec409d to ba868ae Compare August 5, 2026 08:57
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Coverage Report

Coverage report was generated.

Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run).

Overall coverage rate:

lines......: 86.6%
functions......: 54.3%

- include headers via sysroot
- update to clang 18
- use compile flags from llvm toolchain
@hoe-jo
hoe-jo force-pushed the joho_hermetic_libclang branch from ba868ae to e717873 Compare August 5, 2026 09:36
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Coverage Report

Coverage report was generated.

Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run).

Overall coverage rate:

lines......: 86.6%
functions......: 54.2%

@LittleHuba
LittleHuba merged commit c5ff8ce into main Aug 5, 2026
16 checks passed
@LittleHuba
LittleHuba deleted the joho_hermetic_libclang branch August 5, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants