Skip to content

Rework of component requirements related to snapshots - #337

Open
tizava wants to merge 8 commits into
eclipse-score:mainfrom
etas-contrib:snapshot-comp-req-rework
Open

Rework of component requirements related to snapshots#337
tizava wants to merge 8 commits into
eclipse-score:mainfrom
etas-contrib:snapshot-comp-req-rework

Conversation

@tizava

@tizava tizava commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Snapshots are now explicit (Driven by the users)
  • Snapshots are created from live data (Not from data flushed to disk)
  • New API to acquire status of the snapshot slot (Occupied/Free)
  • General rework and cleanup

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 84e7b4c7-ab48-493b-a5e6-25f71e6113b9
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (36 packages loaded, 10 targets configured)

Analyzing: target //:license-check (80 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 1378 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (139 packages loaded, 2712 targets configured)

Analyzing: target //:license-check (153 packages loaded, 6160 targets configured)

Analyzing: target //:license-check (156 packages loaded, 8084 targets configured)

Analyzing: target //:license-check (156 packages loaded, 8084 targets configured)

Analyzing: target //:license-check (156 packages loaded, 8084 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8133 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8133 targets configured)

Analyzing: target //:license-check (164 packages loaded, 10021 targets configured)

Analyzing: target //:license-check (164 packages loaded, 10021 targets configured)

Analyzing: target //:license-check (164 packages loaded, 10021 targets configured)

Analyzing: target //:license-check (165 packages loaded, 10145 targets configured)

INFO: Analyzed target //:license-check (166 packages loaded, 10271 targets configured).
[14 / 17] Generating Dash formatted dependency file ...; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[16 / 17] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 41.507s, Critical Path: 2.08s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look again on the requirements. It seems to me that they are not fully atomic. You can use https://eclipse-score.github.io/process_description//main/process_areas/requirements_engineering/guidance/requirements_templates.html#gd_temp__req_formulation and also the question if the requirement is testable. Understandable they are.

Comment thread score/kvs/docs/requirements/index.rst Outdated
@anmittag

anmittag commented Jul 21, 2026

Copy link
Copy Markdown
Member

@tizava there are checks failing, please adapt and review comments. please care

@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:11 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:11 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:22 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:22 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:55 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 11:55 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 14:28 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 28, 2026 14:28 — with GitHub Actions Waiting
:tags: inspected

The component shall assign the ID 1 to the newest snapshot and shall increment the IDs of older snapshots accordingly.
The component shall create a new snapshot in the selected snapshot slot when the slot is empty.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The component shall create a new snapshot in the selected snapshot slot when the slot is empty.
The component shall create a new snapshot in the selected snapshot slot when the slot is empty or return an error.

this should be defined for all API's handling snapshots

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with last commit

PandaeDo
PandaeDo previously approved these changes Jul 30, 2026

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My findings are solved

Comment thread score/kvs/docs/requirements/index.rst Outdated
:version: 1
:derived_from: feat_req__persistency__snapshot_create[version==1]
:belongs_to: comp__persistency_kvs[version==1]
:tags: inspected

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed / new requirements needs to be tagged as valid

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with last commit

@tizava
tizava requested a deployment to workflow-approval July 31, 2026 13:08 — with GitHub Actions Waiting
@tizava
tizava requested a deployment to workflow-approval July 31, 2026 13:08 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

5 participants