Skip to content

chore: update Bazel version to 8.6.0 and adjust module dependencies #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderLanin wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

chore: update Bazel version to 8.6.0 and adjust module dependencies #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.5.0
8.6.0
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ bazel-*
_build/

# Auto-generated by score_sphinx_bundle
docs/ubproject.toml
ubproject.toml
8 changes: 2 additions & 6 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
#
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************
module(

@draganbjedov draganbjedov Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you removed version? Each module should have version.

@AlexanderLanin AlexanderLanin Aug 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, modules should not have a version. a version is defined by releasing / by bazel registry.

@hoppe-and-dreams hoppe-and-dreams Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only in root module you may omit the version according to bazel documentation:
https://bazel.build/rules/lib/globals/module#module

version string; default is ''
The version of the module. Can be omitted only if this module is the root module (as in, if it's not going to be depended on by another module). The version must be in a relaxed SemVer format; see the documentation for more details.

@draganbjedov draganbjedov Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes for removing version

@a-zw a-zw Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the MODULE.bazel in the docs-as-code repo root and the score_docs_as_code MODULE.bazel in the registry. The registry overwrites the version according to git tags, so there is no point in writing anything there in the repo.

Removing the version is the right way, otherwise people would think that it matters what is in there.

name = "score_itf",
version = "0.5.0",
compatibility_level = 0,
)
module(name = "score_itf")

###############################################################################
#
Expand Down Expand Up @@ -132,7 +128,7 @@ bazel_dep(name = "platforms", version = "1.0.0")
# Documentation dependencies
#
###############################################################################
bazel_dep(name = "score_docs_as_code", version = "4.5.0")
bazel_dep(name = "score_docs_as_code", version = "6.0.0")

################################################################################
#
Expand Down
Loading