Provide Rust wrapper for memory resouces - #406
Open
eclipse-impl wants to merge 4 commits into
Open
Conversation
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 09:07 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 09:07 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:35 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:35 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:52 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:52 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:53 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 23, 2026 14:53 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Using cc_common_link tells Bazel that it should drive the linking process instead of Rust. Therefore, the necessary configuration for ASan is present, whereas Rustc wouldn't know it. The mangled symbols flag is needed because Rustc mangles the symbols when compiling, and Bazel expects no mangled symbols by default.
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 13:28 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 13:28 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
temporarily deployed
to
workflow-approval
July 28, 2026 15:20 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
eclipse-impl
temporarily deployed
to
workflow-approval
July 28, 2026 15:20 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 16:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 16:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ASan is now properly configured for Rust, and detected a memory leak on `JoinInner::join()`. The code was using `core::mem::forget(self)` to avoid its own `drop()` from joining the thread again. However, `self` contains a `Arc<Packet<T>>` that would then remain with reference count 1, meaning that it would never be freed (memory leak). The fix uses `core::ptr::read` to copy the bytes to a local variable (`packet`), that effectively assumes the Packet's ownership. Thus, when `join()` ends, `packet` goes out-of-scope, and the reference count drops to 0, cleaning up the underlying Packet.
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 16:39 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
eclipse-impl
requested a deployment
to
workflow-approval
July 28, 2026 16:39 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Solves the linking problem on atomic symbols.
eclipse-impl
temporarily deployed
to
workflow-approval
July 29, 2026 09:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
eclipse-impl
temporarily deployed
to
workflow-approval
July 29, 2026 09:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
@arkjedrz have a look please |
eclipse-impl
marked this pull request as ready for review
July 30, 2026 09:29
eclipse-impl
requested review from
4og,
antonkri,
arkjedrz and
pawelrutkaq
as code owners
July 30, 2026 09:29
arkjedrz
reviewed
Jul 31, 2026
arkjedrz
left a comment
arkjedrz
left a comment
Contributor
There was a problem hiding this comment.
It looks okay code-wise. It'll be necessary to introduce directives to AI agents on how to write comments and docs though.
Just for now You can ask Your AI agent to rewrite them in following way:
- Make docs concise and information-bearing.
- Avoid filler, pleasantries, and hedging.
- Write one sentence per line.
- Do not decorate sections (e.g. with long
----------comments). - Do not wrap a sentence across lines, first try to rephrase it to fit.
- Wrap only when unavoidable. Use formatter column limit for comments. Do not wrap Markdown - rephrase or keep as is.
- Double spaces between sentences are unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows Rust applications that interface with C++ to obtain memory resources to pass back to C++, such that the C++ code will allocate from them, allowing for controlling the memory allocation between the languages.