GH-5512 Improve NativeStore corrupt data recovery #5514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmottestad
commented
Oct 13, 2025
core/sail/nativerdf/src/main/java/org/eclipse/rdf4j/sail/nativerdf/datastore/DataFile.java
Show resolved
Hide resolved
hmottestad
commented
Oct 13, 2025
core/sail/nativerdf/src/main/java/org/eclipse/rdf4j/sail/nativerdf/datastore/DataFile.java
Show resolved
Hide resolved
hmottestad
commented
Oct 13, 2025
core/sail/nativerdf/src/main/java/org/eclipse/rdf4j/sail/nativerdf/datastore/IDFile.java
Show resolved
Hide resolved
hmottestad
commented
Oct 13, 2025
| * Signals that data for a given id was recovered heuristically (e.g., by inferring the length from neighboring | ||
| * offsets). Carries the recovered bytes to enable callers to construct a CorruptValue. | ||
| */ | ||
| public class RecoveredDataException extends IOException { |
There was a problem hiding this comment.
annotate internal only
hmottestad
commented
Oct 13, 2025
| @Override | ||
| public String getLabel() { | ||
| if (getInternalID() == 14313522) { | ||
| System.out.println(); |
hmottestad
commented
Oct 13, 2025
| } | ||
|
|
||
| private NativeValue data2value(int id, byte[] data) throws IOException { | ||
| public NativeValue data2value(int id, byte[] data) throws IOException { |
There was a problem hiding this comment.
annotate internal only
hmottestad
commented
Oct 13, 2025
| </appender> | ||
| <root> | ||
| <level value="warn"/> | ||
| <level value="info"/> |
hmottestad
deleted the
GH-5512-improve-nativestore-corrupt-data-recovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5512
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)