Skip to content

GH-4856 include UTF-8 charset in CSV tuple MIME type #5510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-4856 include UTF-8 charset in CSV tuple MIME type #5510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ryresultio/api/src/main/java/org/eclipse/rdf4j/query/resultio/TupleQueryResultFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ public class TupleQueryResultFormat extends QueryResultFormat {
/**
* SPARQL Query Result CSV Format.
*/
public static final TupleQueryResultFormat CSV = new TupleQueryResultFormat("SPARQL/CSV", List.of("text/csv"),
StandardCharsets.UTF_8, List.of("csv"), SPARQL_RESULTS_CSV_URI, NO_RDF_STAR);
public static final TupleQueryResultFormat CSV = new TupleQueryResultFormat("SPARQL/CSV",
List.of("text/csv;charset=UTF-8", "text/csv"), StandardCharsets.UTF_8, List.of("csv"),
SPARQL_RESULTS_CSV_URI, NO_RDF_STAR);

/**
* SPARQL Query Result TSV Format.
Expand Down
17 changes: 17 additions & 0 deletions ...sultio/api/src/test/java/org/eclipse/rdf4j/query/resultio/TupleQueryResultFormatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package org.eclipse.rdf4j.query.resultio;

import static org.assertj.core.api.Assertions.assertThat;

import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

class TupleQueryResultFormatTest {

@Test
@DisplayName("CSV default MIME type should include UTF-8 charset parameter as required by spec")
void csvMimeTypeShouldIncludeCharsetParameter() {
assertThat(TupleQueryResultFormat.CSV.getDefaultMIMEType())
.as("MIME type should advertise UTF-8 charset")
.isEqualTo("text/csv;charset=UTF-8");
}
}
Loading