Skip to content

Implement PKCS authentication #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 140 commits into from
Closed

Conversation

JavaJoeS
Copy link

@JavaJoeS JavaJoeS commented Jan 29, 2024

To enable a PKCS12 context, use org.eclipse.core.pki.util.TemplateForPKIfile. Run it and it creates a template in your .eclipse directory. Edit as needed and then run eclipse. You should end up with a .pki file and your pki certificate passwd will get
encrypted and be available for subsequent eclipse instances. The context for SSL will be available for any eclipse bundle
that checks to see if it already exists prior to creating one, which is how it should work.

See this issue for details

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Test Results

   507 files   -   129     507 suites   - 129   31m 17s ⏱️ - 8m 43s
 3 566 tests  -   379   3 540 ✅  -   382   23 💤 ±0  3 ❌ +3 
11 304 runs   - 1 137  11 131 ✅  - 1 146  164 💤 ±0  9 ❌ +9 

For more details on these failures, see this check.

Results for commit cb1b6ca. ± Comparison against base commit 31e1ef4.

This pull request removes 379 tests.
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testCancelOnRequeue
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testQueueAdd
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testWorker
AllCompareTests org.eclipse.compare.tests.CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFFX
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFTX
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Feb 2, 2024

I see you've been asking for reviews...

This PR is not linked to the following issue so I had to hunt for this related issue:

#728

Also, you've typically been making chains of commits which makes it hard to review and it means this needs to be squashed in the end, which is even more work. Generally it would be better to have one commit, amend it each time, and force push it.

The title of the PR is meaningless.

In the end, I can find no overview or description of what this is all about. Why would I use it? For what would I use it?

The PR contains unrelated changes:

image

The code itself contains many TODOs, lots of e.printStackTrace(), System.err.println, and System.out.println. It seems all exceptions ignored, other than print statement. I've not see DebugLogger.printDebug before. What's that?

Things like this don't follow Java naming conventions:

	private static final String[] cdir = { "C:\\Progra~1\\Java", "C:\\Progra~2\\Java" }; //$NON-NLS-1$ //$NON-NLS-2$

I would hope that nothing needs to find Java in some specific location/drive on my machine...

There's effectively no documentation here. There are no tests either.

To me this does not look finished and does not look ready for review. When it is ready, there needs to be documentation to describe the purpose and the impact. There need to be tests. In the end, someone with expertise in this area will be needed. It looks like days of work would be needed to review this properly making the motivation even more significant.

Copy link
Author

@JavaJoeS JavaJoeS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these files have nothing to do with my submitted bundles and I dont understand why they are appearing as changed, because I did not change them, or rather knowingly change them.

@laeubi
Copy link
Contributor

laeubi commented Feb 5, 2024

because I did not change them, or rather knowingly change them.

@JavaJoeS in your IDE select any file you don't wanted to have changed, then select Replace With > Previous Revision

after that, amend your commit and force push it, these should then be gone, before you add something to the index make sure you really want to submit that change or revert it otherwise.

@laeubi
Copy link
Contributor

laeubi commented Feb 5, 2024

d0989e3 Merge branch 'eclipse-platform:master' into master

@JavaJoeS better squash all your commits into one and rebase instead of merge master branch

@merks
Copy link
Contributor

merks commented Feb 5, 2024

Yes, and use amend followed by a force push to keep the branch to a single commit.

@laeubi laeubi changed the title bundle time Implement PKCS authentication Feb 6, 2024
@JavaJoeS JavaJoeS closed this Mar 13, 2024
@JavaJoeS
Copy link
Author

Attempting to squash down and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants