Split table creation and configuration logic for QuickAccess to fix bold font#3743
Open
xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Split table creation and configuration logic for QuickAccess to fix bold font#3743xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
xpomul wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Fixes eclipse-platform#3742 by splitting createTable() into the table creation logic and the table configuration logic. The former is executed as it was, but the latter is postponed until after the Dialog Font preferences have been applied. Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3742 by splitting createTable() into the table creation logic and the table configuration logic.
The former is executed as it was, but the latter is postponed until after the Dialog Font preferences have been applied, namely after PopupDialog.createContents() has completely been executed.
This PR contains three things, in detail: