Remove WS_CARBON check #3077
Closed
Remove WS_CARBON check #3077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 778 files ±0 2 778 suites ±0 1h 38m 20s ⏱️ - 8m 49s For more details on these failures, see this check. Results for commit 12c4eba. ± Comparison against base commit bb94f85. ♻️ This comment has been updated with latest results. |
The Carbon backend is no longer used or supported in SWT, as all modern macOS environments use the Cocoa backend (WS_COCOA). This check is now obsolete and can be removed.
elsazac
force-pushed
the
deprecatedCarbonCheck
branch
from
087912d to
12c4eba
Compare
This commit updates the painting logic of FormText to render the entire content every time, rather than in segments. Painting in parts—particularly during scrolling—can introduce precision loss when using fractional (e.g., 1.25x, 1.75x) scaling factors. This may result in skipped pixels and visual glitches in the UI. Fixes: eclipse-platform#2997
Replacing Image(Display, int, int) with Image(Display, ImageGcDrawer, int, int) in Tests
Currently the BackgroundThread is an inner class of the AbstractReconciler and is tightly coupled with it what makes it quite hard to understand the interaction between both and to properly update a reconciler on document changes or refactor the code. This is a first attempt to decouple the things by extracting the inner class in an own (package private) type to allow further refactoring operations and proper encapsulation.
Currently the Job Framework is not designed for handling more than a few running jobs and certain actions are considerably delayed once a job is active for a longer time. Because of this, now only start the reconciler thread inside a job but perform the actual work in an own thread. Fix eclipse-jdt/eclipse.jdt.ui#2323
Currently the first thing a reconciler after startup does is to sleep for a while then call initialProcess then start the processing loop (that sleeps again...). This now moves this initial work into the start job so we have a plain processing loop in the thread to make further improvements easier.
- add new IScopeChangedListener, IScopeChangeProvider, ScopeChangedEvent classes - have SearchDialog implement new IScopeChangeProvider - bump up minor version with new public interfaces - fixes eclipse-platform#3096
…ChangedListener.java Co-authored-by: Federico Jeanne <[email protected]>
…ui/SearchDialog.java Co-authored-by: Patrick Ziegler <[email protected]>
…hangedEvent.java Co-authored-by: Federico Jeanne <[email protected]>
Currently CompatibilityEditor.createPart(WorkbenchPartReference) eagerly fetches the input just to then check if it is actually needed. This now pulls out the check for MultiEditor out to only fetch the input if there is a demand for it.
This extends the check added in cff785d to also consider the case when OSGi isn't running. Otherwise a path to a non-existent file is returned, thus breaking the contract specified in the JavaDoc.
The changes done with cee4631 cause an exception when an URL is passed as argument, which contains improperly escaped characters (most noticeably whitespaces) and therefore causes an URISyntaxException when calling URL.toURI(). This does not occur when using IPath.fromOSString(), which is the approach that was done previously. But instead of converting this path back to an OS-dependent string, it is instead converted to a file, to check whether it exists and to only then convert it back to its String representation. A test case with an ill-formed URL has been added to avoid a similar problem in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the only remaining WS_CARBON check from the codebase.The Carbon backend is no longer used or supported in SWT, as all modern macOS environments use the Cocoa backend (WS_COCOA). This check is now obsolete and can be removed. (#2964)