Skip to content

In Project Explorer view, added a separator after the 'Refresh' command #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deepika-u
Copy link
Contributor

In Project Explorer view, Added a separator between the 'Refresh' command which is dangerously close to the 'Close projects' and related menu.

Fixes #267

Before the pr, "Project Explorer" showed the context menu like below
image

After the pr, "Project Explorer" was added with a separator which optically improves the context menu look.
image

@deepika-u deepika-u marked this pull request as draft April 7, 2025 07:32
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b0dc4f45aa5bc80e93c2a6d7051ec26be698b01e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 7 Apr 2025 07:37:25 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 52eee57bc2..c93617cfe9 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.600.qualifier
+Bundle-Version: 3.9.700.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@deepika-u deepika-u marked this pull request as ready for review April 7, 2025 07:37
@deepika-u deepika-u force-pushed the issue_267 branch 2 times, most recently from b53426b to 0284e06 Compare April 7, 2025 07:59
@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Apr 7, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From a2a994999a77c1b3a7fde8b5dc4e1c2ebd237c63 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 7 Apr 2025 11:09:39 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
index 133d49280f..84f1f570db 100644
--- a/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundlename
 Bundle-SymbolicName: org.eclipse.ui.tests.navigator;singleton:=true
-Bundle-Version: 3.8.0.qualifier
+Bundle-Version: 3.8.100.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.resources,
  org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Test Results

0 files   -  1 824  0 suites   - 1 824   0s ⏱️ - 1h 37m 15s
0 tests  -  7 918  0 ✅  -  7 690  0 💤  - 228  0 ❌ ±0 
0 runs   - 23 841  0 ✅  - 23 093  0 💤  - 748  0 ❌ ±0 

Results for commit 9774087. ± Comparison against base commit 766f285.

♻️ This comment has been updated with latest results.

@deepika-u deepika-u force-pushed the issue_267 branch 2 times, most recently from 7f18328 to 7a98ae6 Compare April 7, 2025 11:04
@deepika-u
Copy link
Contributor Author

deepika-u commented Apr 7, 2025

@iloveeclipse @mickaelistria
Could you please check this when you have some time?

@elsazac
Copy link
Member

elsazac commented Apr 15, 2025

The change looks good to me. If there are no objections, I would like to proceed with merging the changes.

@deepika-u deepika-u force-pushed the issue_267 branch 2 times, most recently from 2592db1 to 363aead Compare April 21, 2025 06:21
@elsazac elsazac force-pushed the issue_267 branch 2 times, most recently from 819755a to 1faa7d0 Compare April 23, 2025 05:38
@elsazac
Copy link
Member

elsazac commented Apr 23, 2025

@merks Are these test failures related to the issue https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 ?

@iloveeclipse
Copy link
Member

@elsazac
Copy link
Member

elsazac commented Apr 23, 2025

Sure, see https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2891/17/console

Would you recommend merging now, or waiting until the git issue is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Explorer view context menu
4 participants