[GTK] Implement Display.getHighContrast #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gtk ships with "HighContrast" and "HighContrastInverse" and Mate desktop ships "ContrastHigh*" theme. If the gtk theme is any of these say it's "high contrast" theme.
|
Maybe a dumb thought. But are there low contrast themes? Maybe one could just check for contrast and assume high. |
|
If GTK and theme developers claim only a few of these are "HighContrast" I would trust them rather than provide new meaning of the same terms. |
|
I have searched a bit and there seem to be efforts for "low contrast" themes https://www.gnome-look.org/p/1013697 . It's in the description but nothing guarantees that no one named a theme "LowerContrast"/"LessContrast" or anything similar. |
|
As per previous comments I'm merging this one. It's better to have 100% sure API than "guesses". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gtk ships with "HighContrast" and "HighContrastInverse" and Mate desktop ships "ContrastHigh*" theme. If the gtk theme is any of these say it's "high contrast" theme.