Refactor fillGradientRectangle to avoid DPIUtil.autoScaleDown() #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunjose696
force-pushed
the
arunjose696/319/fillGradientRectangle
branch
from
5c3435f to
3035e8f
Compare
|
The changes made here are similar to this PR about refactoring the DPIUtil. We might be working on the same thing, could you check and confirm? |
Yes, the changes are mostly similar. The only additional thing I'm doing is replacing Image constructors that take ImageData with ones that use an ImageDataProvider. I think this change can wait until #2281 is merged |
|
@arunjose696 #2281 is merged. You can resolve the conflicts and mark this one as ready for review. |
fillGradientRectangle() This PR refactors the image creation logic in fillGradientRectangle() by using an ImageDataProvider instead of directly creating ImageData. There is no visual impact for the changes the behavior should remain as before.
arunjose696
force-pushed
the
arunjose696/319/fillGradientRectangle
branch
from
3035e8f to
f497de4
Compare
Have resolved conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR replaces the use of DPIUtil.autoScaleDown() with DPIUtil.scaleDown() in the fillGradientRectangle method. It also refactors the image creation logic by introducing an ImageDataProvider instead of directly creating ImageData. These changes have no visual impact. the behavior remains consistent with previous versions.
Steps to reproduce
Reaching this function on Windows is difficult, as the check usually returns true, causing the method to be bypassed. For testing purposes, this condition can be manually set to false to ensure that fillGradientRectangle is executed.
When the check is disabled, the method is invoked, for example, when using palettes in GEF. After applying this change, the gradient rectangles in the palette render identical as before.