[Win32] Move OS-version-related functionality to OsVersion class #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 539 files - 6 539 suites - 6 31m 48s ⏱️ + 2m 41s For more details on these failures, see this check. Results for commit 32158e3. ± Comparison against base commit eac27cd. This pull request removes 37 tests.♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
win32-osversion-cleanup
branch
2 times, most recently
from
b408f62 to
3ec6d15
Compare
HannesWell
reviewed
May 5, 2025
...s/org.eclipse.swt/Eclipse SWT PI/win32/org/eclipse/swt/internal/win32/version/OsVersion.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
win32-osversion-cleanup
branch
from
3ec6d15 to
77655b5
Compare
With the separation of the OS version check to the separate OsVersion class/DLL, version concerns have been spread over the OS and the OsVersion classes. This change consistently moves every such logic to the OsVersion class. It also replaces the manual checks of the current OS version against a specified version by an easy-to-read access to according constants identifying whether the current system is at least a specific Windows build version.
HeikoKlare
force-pushed
the
win32-osversion-cleanup
branch
from
77655b5 to
32158e3
Compare
|
Failing test is unrelated: #1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the separation of the OS version check to the separate OsVersion class/DLL, version concerns have been spread over the OS and the OsVersion classes. This change consistently moves every such logic to the OsVersion class. It also replaces the manual checks of the current OS version against a specified version by an easy-to-read access to according constants identifying whether the current system is at least a specific Windows build version.
Follow up to: