Disabled Icon Viewer Snippet #1740
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Snippet384 to inspect the behaviour of current icon disabling algorithms and propose new ones.
Changed HSB disabling to a more genralized version, added eclipse mojo disabling and dark themes.
Fixed Combobox default theme
Cleanup
Added alpha slider for additional gray disabling.
HeikoKlare
force-pushed
the
icon-disabling
branch
from
2c19d8f to
19f1856
Compare
HeikoKlare
reviewed
Apr 24, 2025
There was a problem hiding this comment.
@killingerm I think it would be nice to have this snippet in the repository, even though we already have multiple algorithms implemented productively now, as it allows for easier testing of alternatives and reconfigurations.
To do so, would you please squash your commits into one and sign the Eclipse Contributor Agreement (ECA)?
In addition, we need to link the new snippet in the Snippets.md file at the root of the org.eclipse.swt.snippets bundle. I would propose to add this snippet to the Image section of that markdown file.
| import org.eclipse.swt.layout.*; | ||
| import org.eclipse.swt.widgets.*; | ||
|
|
||
| public class Snippet384 { |
There was a problem hiding this comment.
Please add a comment to the class used as the description of the snippet shown in the snippet explorer (see other snippets for a template).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft includes
Snippet384to inspect the behavior of the current icon-disabling algorithms implemented in the constructor oforg.eclipse.swt.graphics.Image(Device, Image, int)when called with theSWT.IMAGE_DISABLEflag.Currently, there are two different algorithms depending on whether Windows/MacOS or Linux is used. The Windows/MacOS implementation is outdated, and the generated disabled icons often look unappealing.
The snippet includes two new algorithms that can serve as a foundation for deriving a new algorithm, with adjustable parameters. This unified approach could also be applied to the Eclipse icons provided in disabled state, ensuring consistent appearance across all disabled icons, whether included in Eclipse JARs or generated dynamically using the
Imageconstructor.How to Use
Example Images
I have included example images that demonstrate the weaknesses of the current algorithms and created a resource folder:
resources/Snippet384/Example Images.For detailed information and to participate in discussions about changes to the algorithm, please refer to the accompanying discussion thread.