Skip to content

Conversation

@amelodev
Copy link
Contributor

This request replace PR #2000, fixing an incorrect commit name.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Test Results

   771 files  ±0     771 suites  ±0   1h 2m 29s ⏱️ - 2m 31s
 3 633 tests ±0   3 579 ✅ ±0   54 💤 ±0  0 ❌ ±0 
10 833 runs  ±0  10 670 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 83b2536. ± Comparison against base commit b235a27.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #2000 (comment):

This PR has to be closed because of a commit name issue. Replaced by #2023

As explained in #2026 (comment), please try to avoid creating new PRs. For just adapting the change to suggestion that's not necessary.

Besides that this change looks better already. Thanks for the update and the delayed reply.
I just have a few minor follow-up remarks below.

@iloveeclipse
Copy link
Member

@amelodev : merge commits are not allowed. Please always rebase your branch on top of master, do not merge!

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Oct 24, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From fc230baab10483d797e1fc8c48e7625123713630 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Tue, 28 Oct 2025 18:32:50 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
index c43b53608e..ec29613868 100644
--- a/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.runtime; singleton:=true
-Bundle-Version: 3.8.800.qualifier
+Bundle-Version: 3.8.900.qualifier
 Bundle-Activator: org.eclipse.pde.internal.runtime.PDERuntimePlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@amelodev amelodev force-pushed the issue-1626_githubLinkInPlugInSpy branch from 32e5fa0 to 30a62db Compare October 24, 2025 14:59
@amelodev
Copy link
Contributor Author

@amelodev : merge commits are not allowed. Please always rebase your branch on top of master, do not merge!

Sorry, i updated PR locally and removed the ugly merge commit :-)

@amelodev amelodev force-pushed the issue-1626_githubLinkInPlugInSpy branch 3 times, most recently from afd033e to 9c68ed3 Compare October 24, 2025 15:42
@HannesWell HannesWell force-pushed the issue-1626_githubLinkInPlugInSpy branch from d20ec77 to 1aa15ff Compare October 28, 2025 05:52
String bundle = href.substring(BUNDLE_PROTOCOL_PREFIX.length());
SpyIDEUtil.openBundleManifest(bundle);
fDialog.close();
} else if (PATTERN.matcher(href).find()) {
Copy link
Member

@HannesWell HannesWell Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use find() here having the regex to end with \\S+ is not really useful as it will just stop the match of the stubstring e.g. on the the first whiespace.
My proposal is to either use match(), which then requires the entire string to match the pattern (and in this case you can also remove the leading ^ from the pattern) or to continue with find(), but remove the trailing \\S+ from the pattern.
I personally would prefer the former.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied this and pushed the change to your PR branch. I also took the opportunity to make the variable name a bit more descriptive.

@HannesWell HannesWell force-pushed the issue-1626_githubLinkInPlugInSpy branch from 5bdaad6 to 43fda1f Compare October 28, 2025 18:22
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this enhancment of the Spies.

I just have pushed an update with a few minor adjustments of the code, mainly style improvements and to fix the new warnings.
With that this should be ready for submission.

@HannesWell HannesWell merged commit 9cf237e into eclipse-pde:master Oct 28, 2025
19 checks passed
@opcoach
Copy link
Contributor

opcoach commented Oct 28, 2025

Thank you @amelodev and @HannesWell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants