addingProtobufDependencyPatch - #55
Conversation
added the dependency to protobuf 5.29.6
|
This need the Eclipse ECA signed for the mails used in the commits. (i.e. make an account on https://www.eclipse.org and add your Github handle to your profile and "sign" (a checkbox there) the Eclipse ECA (The Dash failure here is a seperate issue and not related) |
|
Hi, thanks, ECA looks fine now , and we can ignore the markdown check (some outdated sdv API links), However, wouldn't a more relaxed pin such as |
added upper limit to the protobuf version
|
Hi @SebastianSchildt you are absolutely right adding the upper limit makes it safer to use. I was thinking of a fail early approach. But I am totally fine with yours and @aki1770-del proposal. I added it to my PR. I hope this is fine right now :) |
|
Thank you, lgtm 🍎 |
|
Thanks a lot for merging :) |
adding the protobuf dependency to the pyproject.toml and setup.cfg, as proposed here #54 by @erikbosch