Skip to content

addingProtobufDependencyPatch - #55

Merged
SebastianSchildt merged 4 commits into
eclipse-kuksa:mainfrom
psch0rr:main
Jul 7, 2026
Merged

addingProtobufDependencyPatch#55
SebastianSchildt merged 4 commits into
eclipse-kuksa:mainfrom
psch0rr:main

Conversation

@psch0rr

@psch0rr psch0rr commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

adding the protobuf dependency to the pyproject.toml and setup.cfg, as proposed here #54 by @erikbosch

@SebastianSchildt

Copy link
Copy Markdown
Contributor

This need the Eclipse ECA signed for the mails used in the commits.

(i.e. make an account on https://www.eclipse.org and add your Github handle to your profile and "sign" (a checkbox there) the Eclipse ECA

(The Dash failure here is a seperate issue and not related)

@SebastianSchildt

Copy link
Copy Markdown
Contributor

Hi, thanks, ECA looks fine now , and we can ignore the markdown check (some outdated sdv API links),

However, wouldn't a more relaxed pin such as protobuf>=5.29.6,<6.0dev as suggested in #57 be better for users? If you agree maybe change this. Or try to convince me otherwise

added upper limit to the protobuf version
@psch0rr

psch0rr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Hi @SebastianSchildt you are absolutely right adding the upper limit makes it safer to use. I was thinking of a fail early approach. But I am totally fine with yours and @aki1770-del proposal. I added it to my PR.

I hope this is fine right now :)

@SebastianSchildt

Copy link
Copy Markdown
Contributor

Thank you, lgtm 🍎

@SebastianSchildt
SebastianSchildt merged commit fef6e9d into eclipse-kuksa:main Jul 7, 2026
7 of 8 checks passed
@psch0rr

psch0rr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Thanks a lot for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants