Add SVGs to org.eclipse.jdt.junit #2179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds SVGs for all icons in the bundle
org.eclipse.jdt.junit
.For some icons the icon path is constructed in the following method by adding icon disablement information. Changing these paths works fine:
org.eclipse.jdt.internal.junit.ui.JUnitPlugin.setImageDescriptors(IAction, String, String)
The affected icons are found in the class
TestRunnerViewPart
:history_list.png
stop.png
relaunch.png
relaunchf.png
Please also note that the icon
time_obj.svg
from the images repository had a massive amount of linear gradients that were not visible but lead to JSVG crashing. I fixed the icon and reduced the icon size by factor 70 in this PR in the images repository.I added the fixed icon in this PR and now it works fine.