Skip to content

Add SVGs to org.eclipse.jdt.junit #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

Michael5601
Copy link
Contributor

This commit adds SVGs for all icons in the bundle org.eclipse.jdt.junit.

For some icons the icon path is constructed in the following method by adding icon disablement information. Changing these paths works fine: org.eclipse.jdt.internal.junit.ui.JUnitPlugin.setImageDescriptors(IAction, String, String)

The affected icons are found in the class TestRunnerViewPart:

  • history_list.png
  • stop.png
  • relaunch.png
  • relaunchf.png

Please also note that the icon time_obj.svg from the images repository had a massive amount of linear gradients that were not visible but lead to JSVG crashing. I fixed the icon and reduced the icon size by factor 70 in this PR in the images repository.

I added the fixed icon in this PR and now it works fine.

Michael5601 and others added 2 commits April 23, 2025 12:31
This commit adds SVGs for all icons in the bundles `org.eclipse.jdt.junit`.

For some icons the icon path is constructed in the following method by adding icon disablement information. Changing these paths works fine:
`org.eclipse.jdt.internal.junit.ui.JUnitPlugin.setImageDescriptors(IAction, String, String)`

The affected icons are found in the class `TestRunnerViewPart`:
- `history_list.png`
- `stop.png`
- `relaunch.png`
- `relaunchf.png`
@eclipse-jdt-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.junit/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 8aaf7de0354ba0f729e13f1c109ba4005ad318bb Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <[email protected]>
Date: Wed, 23 Apr 2025 11:35:05 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/org.eclipse.jdt.junit/META-INF/MANIFEST.MF b/org.eclipse.jdt.junit/META-INF/MANIFEST.MF
index 656457b5e9..98a8227a85 100644
--- a/org.eclipse.jdt.junit/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.junit/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.jdt.junit
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.junit;singleton:=true
-Bundle-Version: 3.17.0.qualifier
+Bundle-Version: 3.17.100.qualifier
 Bundle-Activator: org.eclipse.jdt.internal.junit.ui.JUnitPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is sound.

It adopts the support for SVGs added to SWT in order to provide sharp icons for any, even fractional zoom from a single source: eclipse-platform/eclipse.platform.swt#1638

Disabled icons are not replaced by SVGs but are to be replaced with on-the-fly generation from the enabled version, see:

The unnecessary specification of hover images, which is also affected by this PR, is removed with:

@jjohnstn jjohnstn merged commit 8b9f386 into eclipse-jdt:master Apr 28, 2025
10 checks passed
@jjohnstn jjohnstn self-assigned this Apr 28, 2025
@jjohnstn jjohnstn added this to the 4.36 M2 milestone Apr 28, 2025
@Michael5601 Michael5601 deleted the org.eclipse.jdt.junit.SVGs branch April 29, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants