Skip to content

Add drag & drop support from Variables and Expressions to Debug Shell#842

Merged
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:DebugShell
Feb 5, 2026
Merged

Add drag & drop support from Variables and Expressions to Debug Shell#842
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
SougandhS:DebugShell

Conversation

@SougandhS
Copy link
Member

@SougandhS SougandhS commented Jan 29, 2026 •
edited
Loading

Allow variables and expressions to be dragged from their respective views and inserted into the Debug Shell at the caret location.

Drg.mp4

What it does

How to test

Author checklist

@SougandhS SougandhS force-pushed the DebugShell branch 2 times, most recently from 62d68dc to 40a7225 Compare January 29, 2026 05:56
@SougandhS SougandhS added the enhancement New feature or request label Jan 29, 2026
@SougandhS
Copy link
Member Author

SougandhS commented Jan 29, 2026

Hi @iloveeclipse, do you have any suggestions on this PR ?

@SougandhS
Copy link
Member Author

SougandhS commented Feb 5, 2026

Hi @iloveeclipse, do you have any suggestions on this PR ?

I hope this one is good to go ...I’m planning to merge it before M3.

@iloveeclipse iloveeclipse requested a review from Copilot February 5, 2026 07:00
@iloveeclipse
Copy link
Member

iloveeclipse commented Feb 5, 2026

I'm not familiar with DND, but it looks OK except one small issue I've noticed above with the extra space added.

Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds drag and drop functionality to the Debug Shell (Display View), allowing variables from the Variables view and expressions from the Expressions view to be dragged and dropped into the Debug Shell at the caret position.

Changes:

  • Enhanced initDragAndDrop() method to support drop operations in addition to existing drag support
  • Added handling for IVariable and IWatchExpression objects via LocalSelectionTransfer
  • Implemented drop event handlers for visual feedback and text insertion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SougandhS
Add drag & drop support from Variables and Expressions to Debug Shell
1199a01 
Allow variables and expressions to be dragged from their respective
views and inserted into the Debug Shell at the caret location.
iloveeclipse
iloveeclipse approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iloveeclipse iloveeclipse merged commit d419df0 into eclipse-jdt:master Feb 5, 2026
13 checks passed
@iloveeclipse
Copy link
Member

iloveeclipse commented Feb 5, 2026

Thanks. Please also add N&N entry.

@SougandhS
Copy link
Member Author

SougandhS commented Feb 5, 2026

Thank you @iloveeclipse

Please also add N&N entry.

will include this in N&N 👍

@SougandhS SougandhS added this to the 4.39 M3 milestone Feb 5, 2026
@SougandhS SougandhS deleted the DebugShell branch February 5, 2026 08:11
@SougandhS SougandhS mentioned this pull request Feb 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

4.39 M3

Development

Successfully merging this pull request may close these issues.

2 participants

@SougandhS @iloveeclipse