Add preference page for the stack frames grouping feature#801
Open
gzsombor wants to merge 1 commit intoeclipse-jdt:masterfrom
Open
Add preference page for the stack frames grouping feature#801gzsombor wants to merge 1 commit intoeclipse-jdt:masterfrom
gzsombor wants to merge 1 commit intoeclipse-jdt:masterfrom
Conversation
Contributor
|
FYI, warnings should vanish once you rebase (to benefit from #802). |
gzsombor
force-pushed
the
grouping-preference-page
branch
from
701df51 to
c48cc99
Compare
Contributor
Author
|
@iloveeclipse could you please have a look on it? |
Member
I'm sorry, too busy with other tasks. It's on my list for tomorrow. |
Member
|
Sorry, I probably was not clear here: I only asked for the preference page for the "Collapse stack frames", and the rest with the new highlighting feature in a different PR. What I see is the preference page for everything, even for features that are not yet there: I would be happy to merge the preference page change if the only would allow to configure available "Collapse stack frames" feature. Could you please make it, or should I change the PR to cover only that feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds a preference page for the stack frame grouping feature - this is a stripped down version of #81
How to test
Open Window -> Preferences -> Java -> Debug -> Stack Frames and change the values push button etc
Author checklist