Skip to content

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Nov 24, 2025

  • Rebased work to More flexibility to control server start #25790
  • Originally I had no time to finished that and those race conditions were quite rare, but in More flexibility to control server start #25790 they became very noisy.
  • The main problem is very bad design of CORBA-ORB modules and the initialization of this feature. It is easy to get into a recursion of failures causing a StackOverflowl.
  • Yet before an hour it was happening with glassfish-static, when it restarted, and old one did not manage to close listeners before the new one tried to enable them. Before this change it was more often a race condition causing an exception, but which did not end in never ending root.
  • However now I cannot reproduce it any more, I guess CI has to try it too.

This is what I am running locally. The ejb_group_2 is another option.

./rm-generated.sh && mvn clean install -Pfastest -T4C && ./runtests.sh ejb_group_embedded

EDIT, TODO ... ejb_group_2 failed immediately.

@dmatej dmatej force-pushed the corba branch 2 times, most recently from e4d5cc5 to ae5e0d2 Compare November 25, 2025 03:43
@dmatej
Copy link
Contributor Author

dmatej commented Nov 25, 2025

FIXME: In #25790 I have collided with incorrect CORBA lifecycle, which can leave "zombie ports" open after shutdown. I added just some fixme to the code, and three partial workarounds to avoid it. Part of the problem could be also tests which probably don't close sockets too. The server part should be addressed in this PR - as I already refactored it a lot, it should be easier to add those sockets to some list, so they could be safely closed regardless on which other threads are using them.
Starts+stops+restarts are faster and faster, that makes the old tech debt crawling like a zombie. I added few bugs too.

- Some user messages moved to later phase so user would not miss them
- Better separation of server and embedded, now I can see what is not
  supported by embedded's launcher
- Improved user output.

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- other are rather experimental, so I will not document them for now

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Fixed bug I made in 2024-02 in 6f6b961 which
  destroyed ORB restarts.

Signed-off-by: David Matějček <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant