Skip to content

Set of smaller improvements #25797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 21, 2025
Merged

Set of smaller improvements #25797

merged 9 commits into from
Nov 21, 2025

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Nov 21, 2025

Split from #25790

  • Fixed asadmin.java.java in logs
  • ThreadPoolMonitoringITest
    • more aggressive waitFor reduces dependency on timing (but doesn't remove it)
    • HttpLoadGenerator should not just interrupt itself, but stop executor and return immediately
    • waitForTaskCountStoppedChanging will make pauses; that is probably a bug in monitoring, because Grizzly updates that task number very late after processing for some reason.
  • ProgressStatusFailITest
    • timeout could not guarantee those 33%
    • switched to regular "ticking" - client can see timeout somewhere between 0 and 100.
  • runtests.sh
  • rm-generated.sh
    • Some of Bash+Ant based tests create garbage in the project directory, this script resets files back to the original state. Use with care some tests make changes in-place.

@dmatej
Removing garbage after TCK CDI execution
4838fcc 
Signed-off-by: David Matějček <[email protected]>
@dmatej
When interrupted, shutdown the executor asap too.
0f276fd 
Signed-off-by: David Matějček <[email protected]>
@dmatej
More stable ProgressStatusFailITest
08b4983 
- In fact we don't have control over the timing.

Signed-off-by: David Matějček <[email protected]>
@dmatej
Stabilizing ThreadPoolMonitoringTest
46f86a6 
- For some reason the task count increases with big latency
- Instead I removed the sleeping from waitFor, so that one will repeat a lot.

Signed-off-by: David Matějček <[email protected]>
@dmatej
Fixed duplicit filename suffix in the output
f6e70da 
Signed-off-by: David Matějček <[email protected]>
@dmatej
Print all commands to decrease my confusion in Ant+Bash based tests
74aa1f0 
Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added this to the 7.1.0 milestone Nov 21, 2025
@dmatej dmatej self-assigned this Nov 21, 2025
@dmatej dmatej added bug Something isn't working build and test improvement labels Nov 21, 2025
@dmatej dmatej requested a review from a team November 21, 2025 21:33
@dmatej dmatej mentioned this pull request Nov 21, 2025
Merged
@arjantijms arjantijms merged commit c4283da into eclipse-ee4j:master Nov 21, 2025
6 checks passed
@dmatej dmatej deleted the builds branch November 21, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees

@dmatej dmatej

Labels

bug Something isn't working build and test improvement

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dmatej @arjantijms