Delete the terminal test module that was migrated to platform #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruspl-afed
reviewed
Jul 29, 2025
|
The test have always only tested the terminal.control so the scope is already a bit limited, so I doubt that anything useful will be tested here, but it would of course be something for the CDT team to decide. |
I think it is fine to delete it. If new tests are added it can be added back in. |
|
@jonahgraham @ruspl-afed could we then proceed on this? |
|
I was waiting for explicit +1 from @jonahgraham , since it was relatively late in release cycle. |
|
Explicit +1 - the 2025-09 branch is created and the main branch has been updated now that #1297 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonahgraham @ruspl-afed I don't think it is useful here anymore.