Skip to content

ci: Add UI building to build and test workflow #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Etsija
Copy link
Contributor

@Etsija Etsija commented Apr 23, 2024

Add UI building to the corresponding workflow, to automatically assess the buildability of the UI codebase after Renovate Bot 's suggested UI dependency updates. Use caching to reduce installation time.

This resolves #126.

@sschuberth
Copy link
Contributor

What's the rationale for a whole separate workflow, instead of a separate job in the existing https://github.com/eclipse-apoapsis/ort-server/blob/main/.github/workflows/build-and-test.yml?

@Etsija
Copy link
Contributor Author

Etsija commented Apr 23, 2024

What's the rationale for a whole separate workflow, instead of a separate job in the existing https://github.com/eclipse-apoapsis/ort-server/blob/main/.github/workflows/build-and-test.yml?

Nothing, this is a draft PR because I wanted to first test the UI building part of it, and it ran much faster than the whole build-and-test workflow. Changes to come.

@sschuberth
Copy link
Contributor

it ran much faster than the whole build-and-test workflow.

Note that jobs in a workflow run in parallel. So you wouldn't have to wait for the whole build-and-test workflow to complete just to see the results of your "Build UI" job.

@Etsija Etsija force-pushed the ci-add-build-ui-workflow branch from 30c5735 to bb27f52 Compare April 23, 2024 10:48
@Etsija Etsija changed the title ci: Add a GitHub workflow for UI building ci: Add UI building to build and test workflow Apr 23, 2024
@Etsija Etsija force-pushed the ci-add-build-ui-workflow branch from bb27f52 to 7a85d89 Compare April 23, 2024 10:52
@Etsija Etsija marked this pull request as ready for review April 23, 2024 10:53
@Etsija Etsija force-pushed the ci-add-build-ui-workflow branch 2 times, most recently from 6a7b734 to ca653f3 Compare April 23, 2024 13:01
Add UI building to the workflow, to automatically assess the
buildability of the UI codebase after Renovate Bot 's suggested UI
dependency updates.

Signed-off-by: Jyrki Keisala <[email protected]>
@Etsija Etsija force-pushed the ci-add-build-ui-workflow branch from ca653f3 to 57b64e7 Compare April 23, 2024 13:09
@mnonnenmacher mnonnenmacher added this pull request to the merge queue Apr 23, 2024
Merged via the queue into eclipse-apoapsis:main with commit 5f47c05 Apr 23, 2024
10 checks passed
@Etsija Etsija deleted the ci-add-build-ui-workflow branch April 23, 2024 17:03
@sschuberth sschuberth mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Need a GitHub Action to build the UI
3 participants