Skip to content

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 19, 2024

Bumps ws from 8.16.0 to 8.17.1.

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.16.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 19, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 2.83 MB nedbatchelder
pypi/[email protected] eval, filesystem, network 0 210 kB fishtown-analytics
pypi/[email protected] environment, eval, filesystem, network, unsafe 0 3.21 MB fishtown-analytics
pypi/[email protected] environment, filesystem, network 0 77.9 kB fishtown-analytics
pypi/[email protected] environment, eval, filesystem, network 0 119 kB fishtown-analytics
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 3.21 MB fjetter, jacob.tomlinson, jakirkham, ...5 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 3.93 MB fjetter, jacob.tomlinson, jakirkham, ...5 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 1.25 MB aiordache, ccrone, dev-tooling-team, ...4 more
pypi/[email protected] environment, filesystem, network, shell 0 511 kB aiordache, ccrone, dev-tooling-team, ...4 more
pypi/[email protected] filesystem 0 174 kB asottile, graffatcolmingov
pypi/[email protected] environment, eval, filesystem, network, unsafe 0 76.4 MB gcloudpypi, google_opensource
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 73.3 MB gcloudpypi, google_opensource
pypi/[email protected] environment, eval, filesystem, shell 0 1.33 MB gcloudpypi, google_opensource
pypi/[email protected] environment, eval, filesystem, network, shell 0 2.96 MB TimSwast, gcloudpypi, google_opensource
pypi/[email protected] environment, filesystem, network 0 2.58 MB gcloudpypi, google_opensource
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 6.99 MB gcloudpypi, google_opensource
pypi/[email protected] environment, filesystem 0 1.03 MB roguelynn
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 876 kB static, timothycrosley
pypi/[email protected] environment, eval, filesystem, network, shell 0 13.8 MB kubernetes
pypi/[email protected] environment, eval, filesystem, network, shell 0 14.9 MB kubernetes
pypi/[email protected] eval, filesystem 0 21.9 kB oprypin
pypi/[email protected] environment, eval, filesystem, network 0 14.1 MB squidfunk
pypi/[email protected] environment, eval, filesystem, network, shell 0 6.87 MB d0ugal, mkdocsdeploy, oprypin, ...2 more
pypi/[email protected] environment, shell 0 65.1 kB pawamoy
pypi/[email protected] environment, filesystem 0 111 kB oprypin, pawamoy
pypi/[email protected] environment, eval, filesystem, unsafe 0 408 kB Fuzzyman, berkerpeksag, carthorse-mock, ...3 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 49.2 MB bblommers, jackdanger, mikegrima, ...1 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 54.3 MB bblommers, jackdanger, mikegrima, ...1 more
pypi/[email protected] environment 0 858 kB vemel
pypi/[email protected] environment 0 143 kB vemel
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 45.2 MB ambv, guido, hauntsaninja, ...8 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 62.2 MB MarcoGorelli, datapythonista, jbrockmendel, ...8 more
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 73 MB aclark, hugovk, radarhere, ...1 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 345 kB asottile
pypi/[email protected] environment, filesystem, network 0 371 kB desertaxle, prefect
pypi/[email protected] environment, filesystem, network, shell 0 72.9 kB desertaxle, prefect
pypi/[email protected] environment, filesystem, network 0 145 kB desertaxle, prefect
pypi/[email protected] environment, network 0 111 kB desertaxle, prefect
pypi/[email protected] None 0 0 B
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 136 MB Charles.Cloud, cutlerb, jorgecarleitao, ...6 more
pypi/[email protected] environment, eval, filesystem, unsafe 0 2.46 MB ptmcg
pypi/[email protected] eval, network 0 108 kB Andrew.Svetlov, hpk, m.seifert, ...2 more
pypi/[email protected] eval, network 0 219 kB Andrew.Svetlov, hpk, m.seifert, ...2 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 237 kB ionel
pypi/[email protected] environment, eval, filesystem, network 0 333 kB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network 0 363 kB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.12 MB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.71 MB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 2.03 MB bufferoverflow, max-wittig, nejch
pypi/[email protected] eval, filesystem, shell 0 44.5 kB un33k
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 165 MB amogkamsetty, architkulkarni, artur1993, ...23 more
pypi/[email protected] environment, eval 0 110 kB 5monkeys
pypi/[email protected] environment, eval, filesystem, network, shell 0 269 kB jaraco, jezdez, ronny
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 6.89 MB abravalheri, dstufft, jaraco
pypi/[email protected] environment, eval, filesystem, network 0 547 kB barbieri
pypi/[email protected] environment, filesystem, network, shell 0 1.46 MB filmaj, misscoded, seratch, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 9.95 MB Tianyi, angel.avalos, ankit.bhatnagar, ...7 more
pypi/[email protected] None 0 0 B
pypi/[email protected] eval, unsafe 0 210 kB jd, sileht
pypi/[email protected] None 0 30.6 kB vemel
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 460 kB agronholm, joeforker, natefoo

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

Copy link

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

Copy link

This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it.

@github-actions github-actions bot closed this Jun 29, 2025
Copy link
Author

dependabot bot commented on behalf of github Jun 29, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/ws-8.17.1 branch June 29, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file status:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants