Fix unit tests

README.md

@@ -161,7 +161,10 @@ Checkout and install the dependencies:
 
 #### Run the tests
 
-Start a web server in the project directory and navigate to http://localhost:3000/test/. If you makes changes to the library, be sure to run `gulp` to rebuild the library in `/dist`.
+Run:
+  npm run test
+  // To debug
+  npm run tests:debug
 
 ### License
 

karma.conf.js

@@ -0,0 +1,18 @@
+module.exports = function(config) {
+  config.set({
+    frameworks: ['mocha', 'chai', 'sinon'],
+    preprocessors: {
+      'src/appmetrics.js': ['babel'],
+      'test/**/*.js': ['babel']
+    },
+    files: ['src/appmetrics.js', 'test/**/*.js'],
+    reporters: ['progress'],
+    port: 9876,  // karma web server port
+    colors: true,
+    logLevel: config.LOG_INFO,
+    browsers: ['ChromeHeadless'],
+    autoWatch: false,
+    singleRun: true, // Karma captures browsers, runs the tests and exits
+    concurrency: Infinity
+  });
+};

package.json

@@ -17,7 +17,8 @@
   ],
   "scripts": {
     "lint": "gulp lint",
-    "test": "./node_modules/mocha/bin/mocha",
+    "test": "karma start",
+    "test:debug": "karma start --browsers Chrome --single-run false",
     "release": "npm version patch; gulp; npm publish"
   },
   "repository": {
@@ -30,7 +31,7 @@
   "devDependencies": {
     "babel-core": "^6.13.2",
     "babel-preset-es2015": "^6.13.2",
-    "chai": "^3.5.0",
+    "chai": "^4.1.2",
     "del": "^2.2.1",
     "eslint-config-google": "^0.6.0",
     "gulp": "^3.9.1",
@@ -41,7 +42,14 @@
     "gulp-load-plugins": "^1.2.4",
     "gulp-mocha": "^3.0.0",
     "gulp-rename": "^1.2.2",
-    "mocha": "^3.0.1",
-    "run-sequence": "^1.2.2"
-  }
+    "karma": "^2.0.0",
+    "karma-babel-preprocessor": "^7.0.0",
+    "karma-chai": "^0.1.0",
+    "karma-chrome-launcher": "^2.2.0",
+    "karma-mocha": "^1.3.0",
+    "karma-sinon": "^1.0.5",
+    "run-sequence": "^1.2.2",
+    "sinon": "^4.1.4"
+  },
+  "dependencies": {}
 }

test/test.js

@@ -40,7 +40,9 @@ describe('appmetrics.js', function() {
 
   describe('init', function() {
     it('constructor fails without name', function() {
-      assert.throws(function test() { return new Metric(); });
+      assert.throws(function test() {
+        return new Metric();
+      });
     });
     it('name is correct', function() {
       assert.equal(metric.name, 'test_metric');
@@ -127,80 +129,34 @@ describe('appmetrics.js', function() {
   });
 
   describe('sendToAnalytics()', function() {
-    it('sends default request', function(done) {
-      const observer = new PerformanceObserver(list => {
-        observer.disconnect();
-
-        const entries = list.getEntries().filter(entry => {
-          return isAnalyticsRequest(entry) &&
-                 entry.name.includes(Math.round(metric.duration)) &&
-                 entry.name.includes(metric.name) &&
-                 entry.name.includes('category_name');
-        });
-
-        assert.equal(entries.length, 1, 'single timing entry');
-        done();
-      });
-      observer.observe({entryTypes: ['resource']});
-
+    let spy;
+    beforeEach(() => {
+      spy = sinon.spy(window, 'ga');
+    });
+    afterEach(() => {
+      spy.restore();
+    });
+    it('sends default request', function() {
       metric.sendToAnalytics('category_name');
+      assert(spy.calledWith('send', 'timing', 'category_name', metric.name, Math.round(metric.duration)));
     });
 
-    it('can override duration and name', function(done) {
-      const observer = new PerformanceObserver(list => {
-        observer.disconnect();
-
-        const entries = list.getEntries().filter(entry => {
-          return isAnalyticsRequest(entry) &&
-                 entry.name.includes('1234567890') &&
-                 entry.name.includes('category_name') &&
-                 entry.name.includes('metric_name');
-        });
-
-        assert.equal(entries.length, 1, 'one timing entry');
-        done();
-      });
-      observer.observe({entryTypes: ['resource']});
-
+    it('can override duration and name', function() {
       metric.sendToAnalytics('category_name', 'metric_name', 1234567890);
+      assert(spy.calledWith('send', 'timing', 'category_name', 'metric_name', 1234567890));
     });
 
-    it('can send a duration without measuring', function(done) {
+    it('can send a duration without measuring', function() {
       const duration = Date.now();
-
-      const observer = new PerformanceObserver(list => {
-        observer.disconnect();
-
-        const entries = list.getEntries().filter(entry => {
-          return isAnalyticsRequest(entry) &&
-                 entry.name.includes(duration) &&
-                 entry.name.includes('category_name') &&
-                 entry.name.includes('override_duration');
-        });
-
-        assert.equal(entries.length, 1, 'one timing entry');
-        done();
-      });
-      observer.observe({entryTypes: ['resource']});
-
       const metric = new Metric('override_duration');
       metric.sendToAnalytics('category_name', metric.name, duration);
+      assert(spy.calledWith('send', 'timing', 'category_name', metric.name, duration));
     });
 
-    it('no requests are to GA before a measurement', function(done) {
-      // If the perf observer sees a request, the test should fail.
-      const observer = new PerformanceObserver(list => {
-        observer.disconnect();
-        assert.fail(
-            false, true, 'Google Analytics request was sent before a measurement was made.');
-        done();
-      });
-      observer.observe({entryTypes: ['resource']});
-
+    it('no requests are to GA before a measurement', function() {
       const metric = new Metric('test_metric');
       metric.sendToAnalytics('should_not_be_sent');
-
-      setTimeout(done, 500);
+      assert(spy.notCalled);
     });
   });
 });