-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN release #369
base: main
Are you sure you want to change the base?
Prepare CRAN release #369
Conversation
package modelbased_0.9.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests (additional issue checks): |
We have to wait for marginaleffects 😎 |
I've added a todo list that we need to finish before we submit |
One thing I always forget is that Should we harmonize this? Will be a breaking change, but if we decide to do so, now would be a good opportunity, I guess. |
FYI, |
Please see the problems shown on Please correct before 2025-02-24 to safely retain your package on CRAN. |
Yes, that's expected. We are in principle ready to submit, question is whether you would like to address one, two or none of the above mentioned issues? I could implement them later this day |
by
argument #373marginalize
and its options #374by
matters? vincentarelbundock/marginaleffects#1373 gets fixed for CRAN submission 😎 (and add tests when fixed)