Skip to content

Conversation

@etiennebacher
Copy link
Member

Fixes #664

@mattansb
Copy link
Member

(Cool!)

@etiennebacher
Copy link
Member Author

etiennebacher commented Nov 21, 2025

Ping @strengejacke, I'm not so familiar with standardizing directly the regression results so I'd like a double check on this, just in case there are some gotchas I'm not aware of.

@mattansb
Copy link
Member

The regression results are standardized in {parameters}. Here we refit the model with standardized data.

So generally if these two give the same result, it works.

mod1 <- model_fitting_function(..., data = d)
mod1_z <- standardize(mod1)

mod2_z <- model_fitting_function(..., data = standardize(d))

(Depending link and transformations, might not be exactly the same)

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.75%. Comparing base (9a624b1) to head (54ceae9).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   91.73%   91.75%   +0.02%     
==========================================
  Files          76       76              
  Lines        6410     7664    +1254     
==========================================
+ Hits         5880     7032    +1152     
- Misses        530      632     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@etiennebacher
Copy link
Member Author

Ok I'll go ahead with this, thanks for the review @mattansb

@etiennebacher etiennebacher merged commit 790a1d9 into main Nov 24, 2025
26 of 27 checks passed
@etiennebacher etiennebacher deleted the fixest-update branch November 24, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

standardize(<fixest>) cannot find new data in environment

3 participants