-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for standardize() on objects of class fixest
#665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(Cool!) |
|
Ping @strengejacke, I'm not so familiar with standardizing directly the regression results so I'd like a double check on this, just in case there are some gotchas I'm not aware of. |
|
The regression results are standardized in {parameters}. Here we refit the model with standardized data. So generally if these two give the same result, it works. mod1 <- model_fitting_function(..., data = d)
mod1_z <- standardize(mod1)
mod2_z <- model_fitting_function(..., data = standardize(d))(Depending link and transformations, might not be exactly the same) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 91.73% 91.75% +0.02%
==========================================
Files 76 76
Lines 6410 7664 +1254
==========================================
+ Hits 5880 7032 +1152
- Misses 530 632 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok I'll go ahead with this, thanks for the review @mattansb |
Fixes #664