Skip to content

new param forcekeeppreviousinstall for bwrap #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

new param forcekeeppreviousinstall for bwrap #4890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
471950b
new param forcekeeppreviousinstall for bwrap
May 21, 2025
84d0cd5
update description of keeppreviousinstall
May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,12 @@ def make_builddir(self):
self.cfg['cleanupoldbuild'] = False
else:
self.cfg['cleanupoldbuild'] = True

self.cfg['keeppreviousinstall'] = False
if self.cfg['forcekeeppreviousinstall']:
self.log.info("Forcefully setting 'keeppreviousinstall' (to True) because "
"'forcekeeppreviousinstall' is True.")
self.cfg['keeppreviousinstall'] = True
else:
self.cfg['keeppreviousinstall'] = False
# avoid cleanup after installation
self.cfg['cleanupoldinstall'] = False

Expand Down
5 changes: 4 additions & 1 deletion easybuild/framework/easyconfig/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@
'dontcreateinstalldir': [False, ('Boolean to create (False) or not create (True) the install directory'),
FILEMANAGEMENT],
'keeppreviousinstall': [False, ('Boolean to keep the previous installation with identical '
'name. Experts only!'), FILEMANAGEMENT],
'name (except if buildininstalldir is True). Experts only!'), FILEMANAGEMENT],
'forcekeeppreviousinstall': [False, ('Boolean to forcefully keep the previous installation with identical '
'name, even if buildininstalldir is True. Experts only! Probably only useful '
'when installing in new mount namespace (e.g. with bwrap).'), FILEMANAGEMENT],
'keepsymlinks': [True, ('Boolean to determine whether symlinks are to be kept during copying '
'or if the content of the files pointed to should be copied'),
FILEMANAGEMENT],
Expand Down